From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Enable RGB565 90/270 plane rotation for gen11 onwards.
Date: Wed, 5 Sep 2018 17:58:06 +0300 [thread overview]
Message-ID: <20180905145806.GT5565@intel.com> (raw)
In-Reply-To: <1535373473-3594-3-git-send-email-juhapekka.heikkila@gmail.com>
On Mon, Aug 27, 2018 at 03:37:53PM +0300, Juha-Pekka Heikkila wrote:
> From gen11 onwards RGB565 90/270 plane rotation is supported on hardware.
>
> IGT: https://patchwork.freedesktop.org/series/48756/
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_atomic_plane.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c
> index 344a16b..c245906 100644
> --- a/drivers/gpu/drm/i915/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c
> @@ -123,14 +123,17 @@ static bool intel_plane_valid_rotation(const struct drm_plane_state *plane_state
> }
>
> /*
> - * 90/270 is not allowed with RGB64 16:16:16:16,
> - * RGB 16-bit 5:6:5, and Indexed 8-bit.
> + * 90/270 is not allowed with RGB64 16:16:16:16 and
> + * Indexed 8-bit. RGB 16-bit. 5:6:5 is allowed gen11 onwards.
^
Extra period there
Otherwise lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> * TBD: Add RGB64 case once its added in supported format
> * list.
> */
> switch (plane_state->fb->format->format) {
> - case DRM_FORMAT_C8:
> case DRM_FORMAT_RGB565:
> + if (INTEL_GEN(dev_priv) >= 11)
> + break;
> + /* fall through */
> + case DRM_FORMAT_C8:
> DRM_DEBUG_KMS("Unsupported pixel format %s for 90/270!\n",
> drm_get_format_name(plane_state->fb->format->format,
> &format_name));
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-05 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 12:37 [PATCH 0/2] Enable RGB565 rotation from gen11 onwards Juha-Pekka Heikkila
2018-08-27 12:37 ` [PATCH 1/2] drm/i915: Move 90/270 rotation validity check into its own function Juha-Pekka Heikkila
2018-08-27 12:37 ` [PATCH 2/2] drm/i915: Enable RGB565 90/270 plane rotation for gen11 onwards Juha-Pekka Heikkila
2018-09-05 14:58 ` Ville Syrjälä [this message]
2018-09-25 13:35 ` Maarten Lankhorst
2018-09-25 14:38 ` Juha-Pekka Heikkila
2018-08-27 12:53 ` ✗ Fi.CI.CHECKPATCH: warning for Enable RGB565 rotation from " Patchwork
2018-08-27 13:11 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-27 14:01 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905145806.GT5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox