public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm: Add connector property to limit max bpc
Date: Wed, 05 Sep 2018 20:44:41 -0000	[thread overview]
Message-ID: <20180905204441.5308.13972@emeril.freedesktop.org> (raw)
In-Reply-To: <20180905201200.29414-1-radhakrishna.sripada@intel.com>

== Series Details ==

Series: series starting with [v5,1/2] drm: Add connector property to limit max bpc
URL   : https://patchwork.freedesktop.org/series/49230/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2c48291891eb drm: Add connector property to limit max bpc
44f00038f508 drm/i915: Allow "max bpc" property to limit pipe_bpp
-:32: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#32: FILE: drivers/gpu/drm/i915/intel_display.c:10792:
+connected_sink_max_bpp(struct drm_connector_state *conn_state,
+			     struct intel_crtc_state *pipe_config)

-:37: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#37: FILE: drivers/gpu/drm/i915/intel_display.c:10797:
+		pipe_config->pipe_bpp = 8*3;
 		                         ^

-:41: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#41: FILE: drivers/gpu/drm/i915/intel_display.c:10801:
+		pipe_config->pipe_bpp = 10*3;
 		                          ^

-:47: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#47: FILE: drivers/gpu/drm/i915/intel_display.c:10807:
+		pipe_config->pipe_bpp = 12*3;
 		                          ^

-:50: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#50: FILE: drivers/gpu/drm/i915/intel_display.c:10810:
+		pipe_config->pipe_bpp = 16*3;
 		                          ^

-:136: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#136: FILE: drivers/gpu/drm/i915/intel_modes.c:145:
+	if (prop == NULL) {

-:138: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#138: FILE: drivers/gpu/drm/i915/intel_modes.c:147:
+		if (prop == NULL)

total: 0 errors, 0 warnings, 7 checks, 99 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-09-05 20:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 20:11 [PATCH v5 1/2] drm: Add connector property to limit max bpc Radhakrishna Sripada
2018-09-05 20:12 ` [PATCH v5 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp Radhakrishna Sripada
2018-09-05 22:02   ` [Intel-gfx] " Daniel Vetter
2018-09-06 11:36   ` Ville Syrjälä
2018-09-05 20:44 ` Patchwork [this message]
2018-09-05 21:02 ` ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm: Add connector property to limit max bpc Patchwork
2018-09-06  5:18 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905204441.5308.13972@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=radhakrishna.sripada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox