From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] igt/kms_busy: Flush request queue when re-enabling hangcheck
Date: Tue, 2 Oct 2018 14:53:38 +0300 [thread overview]
Message-ID: <20181002115338.GD17124@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20181002112601.9981-1-chris@chris-wilson.co.uk>
On Tue, Oct 02, 2018 at 12:26:01PM +0100, Chris Wilson wrote:
> Enabling hangcheck only takes effect at the start of a new request
> queue. Before we re-enable hangcheck after our poking around, we
> therefore need to wait until the gpu is idle otherwise the next test
> will start without hangcheck and subsequently hang forever.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Petri Latvala <petri.latvala@intel.com>
Tested-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/kms_busy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_busy.c b/tests/kms_busy.c
> index d821ec711..ed3caae4c 100644
> --- a/tests/kms_busy.c
> +++ b/tests/kms_busy.c
> @@ -138,6 +138,7 @@ static void flip_to_fb(igt_display_t *dpy, int pipe,
> igt_assert(poll(&pfd, 1, 0) == 0);
>
> if (modeset) {
> + gem_quiescent_gpu(dpy->drm_fd);
> igt_set_module_param_int("enable_hangcheck", 1);
>
> /* Clear old mode blob. */
> --
> 2.19.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-10-02 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 11:26 [PATCH i-g-t] igt/kms_busy: Flush request queue when re-enabling hangcheck Chris Wilson
2018-10-02 11:53 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002115338.GD17124@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox