From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Do intel_panel_destroy_backlight() later
Date: Tue, 9 Oct 2018 16:37:15 +0300 [thread overview]
Message-ID: <20181009133715.GH9144@intel.com> (raw)
In-Reply-To: <153901153936.31254.18039914045908431253@skylake-alporthouse-com>
On Mon, Oct 08, 2018 at 04:12:19PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-10-08 14:46:40)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Currently we destroy the backlight during connector unregistration.
> > That means the final modeset performed by drm_atomic_helper_shutdown()
> > will leave the backlight on. We don't want that so let's just move
> > intel_panel_destroy_backlight() into intel_panel_fini() which gets
> > called during connector destuction.
> >
> > We still unregister the user visible backlight device during connector
> > unregistration.
> >
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106386
Thanks for digging that up for me, and for the review.
Series pushed to dinq.
>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-09 13:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 13:46 [PATCH 1/2] drm/i915: Do intel_panel_destroy_backlight() later Ville Syrjala
2018-10-08 13:46 ` [PATCH 2/2] drm/i915: Drop the eDP check from intel_dp_connector_destroy() Ville Syrjala
2018-10-08 14:22 ` Chris Wilson
2018-10-08 14:17 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Do intel_panel_destroy_backlight() later Patchwork
2018-10-08 14:22 ` [PATCH 1/2] " Chris Wilson
2018-10-08 15:12 ` Chris Wilson
2018-10-09 13:37 ` Ville Syrjälä [this message]
2018-10-08 15:35 ` ✓ Fi.CI.IGT: success for series starting with [1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009133715.GH9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox