From: Imre Deak <imre.deak@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Fix power domain reference balance when DMC firmware is not present
Date: Tue, 16 Oct 2018 12:22:03 +0300 [thread overview]
Message-ID: <20181016092203.GA4596@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20181016012946.20146-1-jose.souza@intel.com>
On Mon, Oct 15, 2018 at 06:29:45PM -0700, José Roberto de Souza wrote:
> intel_csr_ucode_init() gets a POWER_DOMAIN_INIT reference but it is
> only released in csr_load_work_fn() if DMC firmware is present in
> filesystem, keeping a reference to POWER_DOMAIN_INIT and every power
> well enabled all the times.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index fc7bd21fa586..7c91a56869e9 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -423,8 +423,6 @@ static void csr_load_work_fn(struct work_struct *work)
> if (dev_priv->csr.dmc_payload) {
> intel_csr_load_program(dev_priv);
>
> - intel_display_power_put(dev_priv, POWER_DOMAIN_INIT);
> -
> DRM_INFO("Finished loading DMC firmware %s (v%u.%u)\n",
> dev_priv->csr.fw_path,
> CSR_VERSION_MAJOR(csr->version),
and for the !dmc_payload case below we print:
"Failed to load DMC firmware, disabling runtime power management."
explaining why we hold on to the reference in that case.
> @@ -439,6 +437,8 @@ static void csr_load_work_fn(struct work_struct *work)
> }
>
> release_firmware(fw);
> +
> + intel_display_power_put(dev_priv, POWER_DOMAIN_INIT);
> }
>
> /**
> --
> 2.19.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-10-16 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 1:29 [PATCH 1/2] drm/i915: Fix power domain reference balance when DMC firmware is not present José Roberto de Souza
2018-10-16 1:29 ` [PATCH 2/2] drm/i915: Do not print DC off mismatch state when DMC firmware in not loaded José Roberto de Souza
2018-10-16 2:04 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix power domain reference balance when DMC firmware is not present Patchwork
2018-10-16 3:00 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-16 8:16 ` [PATCH 1/2] " Chris Wilson
2018-10-16 9:22 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016092203.GA4596@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox