From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/icl: Add get_config functionality for dsi
Date: Tue, 23 Oct 2018 15:09:09 +0300 [thread overview]
Message-ID: <20181023120909.GS9144@intel.com> (raw)
In-Reply-To: <1540292954-19413-4-git-send-email-vandita.kulkarni@intel.com>
On Tue, Oct 23, 2018 at 04:39:14PM +0530, Vandita Kulkarni wrote:
> From: Madhav Chauhan <madhav.chauhan@intel.com>
>
> This patch implements the functionality for getting PIPE
> configuration to which DSI encoder is connected. Used during
> the atomic modeset.
>
> v2: use intel_dsi_bitrate instead of intel_dsi->pclk
>
> Signed-off-by: Madhav Chauhan <madhav.chauhan@intel.com>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
> drivers/gpu/drm/i915/icl_dsi.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c
> index d2bb369..6cb3bf8 100644
> --- a/drivers/gpu/drm/i915/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/icl_dsi.c
> @@ -665,3 +665,16 @@ static void __attribute__((unused))
> /* step6d: enable dsi transcoder */
> gen11_dsi_enable_transcoder(encoder);
> }
> +
> +static void __attribute__((unused))
> +gen11_dsi_get_config(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config)
> +{
> + struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,
> + base);
> + u32 pixel_clk;
> +
> + pixel_clk = intel_dsi_bitrate(intel_dsi);
> + pipe_config->base.adjusted_mode.crtc_clock = pixel_clk;
> + pipe_config->port_clock = pixel_clk;
We're supposed to read the state from the hardware here. See how other
DDI encoders do it.
> +}
> --
> 1.9.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-23 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 11:09 [PATCH 0/3] ICL DSI PLL enable Vandita Kulkarni
2018-10-23 11:09 ` [PATCH 1/3] drm/i915/icl: Use the same pll functions for dsi Vandita Kulkarni
2018-10-23 11:09 ` [PATCH 2/3] drm/i915/icl: Calculate DPLL params for DSI Vandita Kulkarni
2018-10-23 16:22 ` Ville Syrjälä
2018-10-23 11:09 ` [PATCH 3/3] drm/i915/icl: Add get_config functionality for dsi Vandita Kulkarni
2018-10-23 12:09 ` Ville Syrjälä [this message]
2018-10-24 4:48 ` Kulkarni, Vandita
2018-10-23 12:04 ` ✗ Fi.CI.CHECKPATCH: warning for ICL DSI PLL enable Patchwork
2018-10-23 12:12 ` [PATCH 0/3] " Jani Nikula
2018-10-23 12:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-23 15:40 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023120909.GS9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=vandita.kulkarni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox