From: Daniel Vetter <daniel@ffwll.ch>
To: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/dp_mst: Deprecate drm_dp_find_vcpi_slots()
Date: Wed, 24 Oct 2018 10:27:13 +0200 [thread overview]
Message-ID: <20181024082713.GE324@phenom.ffwll.local> (raw)
In-Reply-To: <20181023231251.16883-2-lyude@redhat.com>
On Tue, Oct 23, 2018 at 07:12:46PM -0400, Lyude Paul wrote:
> Because we have drm_dp_atomic_find_vcpi_slots(), which actually takes
> care to update the atomic state of the MST topology, prints valuable
> debugging output, and actually takes references to the ports it's
> checking! This explains some incorrect usage I've been seeing across the
> tree...
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 5ff1d79b86c4..8c3cfac437f4 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -2569,9 +2569,16 @@ struct edid *drm_dp_mst_get_edid(struct drm_connector *connector, struct drm_dp_
> EXPORT_SYMBOL(drm_dp_mst_get_edid);
>
> /**
> - * drm_dp_find_vcpi_slots() - find slots for this PBN value
> + * drm_dp_find_vcpi_slots() - Find VCPI slots for this PBN value
> * @mgr: manager to use
> * @pbn: payload bandwidth to convert into slots.
> + *
> + * Calculate the number of VCPI slots that will be required for the given PBN
> + * value. This function is deprecated, and should not be used in atomic
> + * drivers.
> + *
> + * RETURNS:
> + * The total slots required for this port, or error.
> */
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> int drm_dp_find_vcpi_slots(struct drm_dp_mst_topology_mgr *mgr,
> int pbn)
> --
> 2.17.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-24 8:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 23:12 [PATCH 0/6] drm/dp_mst: Improve VCPI helpers, use in nouveau Lyude Paul
2018-10-23 23:12 ` [PATCH 1/6] drm/dp_mst: Deprecate drm_dp_find_vcpi_slots() Lyude Paul
2018-10-24 8:27 ` Daniel Vetter [this message]
2018-10-23 23:12 ` [PATCH 4/6] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
[not found] ` <20181023231251.16883-5-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-10-24 8:55 ` Daniel Vetter
[not found] ` <20181023231251.16883-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-10-23 23:12 ` [PATCH 2/6] drm/dp_mst: Remove all evil duplicate state pointers Lyude Paul
2018-10-24 8:27 ` Daniel Vetter
2018-10-23 23:12 ` [PATCH 3/6] drm/atomic: Add ->atomic_check() hook for private objects Lyude Paul
2018-10-24 8:45 ` Daniel Vetter
2018-10-23 23:12 ` [PATCH 5/6] drm/dp_mst: Check payload count in ->atomic_check() Lyude Paul
[not found] ` <20181023231251.16883-6-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-10-24 8:54 ` Daniel Vetter
2018-10-23 23:12 ` [PATCH 6/6] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2018-10-24 8:50 ` [PATCH 0/6] drm/dp_mst: Improve VCPI helpers, use in nouveau Daniel Vetter
2018-10-23 23:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-24 3:57 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024082713.GE324@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox