From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use intel_panel_actually_set_backlight() to disable PWM backlight
Date: Wed, 24 Oct 2018 19:33:17 +0300 [thread overview]
Message-ID: <20181024163317.GF9144@intel.com> (raw)
In-Reply-To: <154039693863.5632.15451597580452423383@skylake-alporthouse-com>
On Wed, Oct 24, 2018 at 05:02:18PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2018-10-24 16:52:08)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Use intel_panel_actually_set_backlight() instead of a direct
> > call to pwm_config() in pwm_disable_backlight().
> >
> > The main benefit is consistent debug logging when we turn off the
> > backlight. Currently we see nothing in dmesg which made me wonder
> > whether the backlight was even getting turned off properly.
> >
> > The second benefit is consistency; This is what we do for all
> > the other backlight implementations.
>
> It will also have the effect of calling
> intel_panel_compute_brightness(0) which one presumes is desired?
We do it for everything else so it must be good?
>
> Just worrying if the inverted brightness quirk is ever used with pwm.
If we have to invert for normal operation I don't know why
we wouldn't want to invert when shutting down the backlight.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-24 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 15:52 [PATCH] drm/i915: Use intel_panel_actually_set_backlight() to disable PWM backlight Ville Syrjala
2018-10-24 16:02 ` Chris Wilson
2018-10-24 16:33 ` Ville Syrjälä [this message]
2018-10-24 16:35 ` Chris Wilson
2018-10-24 16:47 ` Ville Syrjälä
2018-10-29 10:34 ` Jani Nikula
2018-10-24 17:38 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-24 22:37 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024163317.GF9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox