From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: Kill WA 0826
Date: Tue, 30 Oct 2018 20:38:44 +0200 [thread overview]
Message-ID: <20181030183844.GG9144@intel.com> (raw)
In-Reply-To: <20181029230044.12876-5-rodrigo.vivi@intel.com>
On Mon, Oct 29, 2018 at 04:00:44PM -0700, Rodrigo Vivi wrote:
> According to BSpec this is not needed anymore:
>
> "This workaround is no longer needed since NV12
> support is dropped for the affected projects.
> "
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Making it harder for me to keep testing NV12 on skl :P
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 9ee96016cfd5..f202b9b3b796 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4823,16 +4823,6 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,
> }
> }
>
> - /*
> - * Display WA #826 (SKL:ALL, BXT:ALL)
> - * disable wm level 1-7 on NV12 planes
> - */
> - if (wp->is_planar && level >= 1 &&
> - (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> - result->plane_en = false;
> - return 0;
> - }
> -
> /* The number of lines are ignored for the level 0 watermark. */
> result->plane_res_b = res_blocks;
> result->plane_res_l = res_lines;
> --
> 2.19.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-30 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 23:00 [PATCH 1/5] drm/i915: Remove CNL from WA 827 Rodrigo Vivi
2018-10-29 23:00 ` [PATCH 2/5] drm/i915/cnl: Remove useless CNL A-stepping workarounds Rodrigo Vivi
2018-10-29 23:57 ` [PATCH] " Rodrigo Vivi
2018-10-29 23:00 ` [PATCH 3/5] drm/i915: Introduce HAS_NV12 and define WA 0870 Rodrigo Vivi
2018-10-30 18:16 ` Ville Syrjälä
2018-10-30 22:15 ` [PATCH] drm/i915: Define WA 0870 and kill dead code Rodrigo Vivi
2018-10-31 13:07 ` Ville Syrjälä
2018-10-29 23:00 ` [PATCH 4/5] drm/i915: Kill WA 0528 Rodrigo Vivi
2018-10-30 18:32 ` Ville Syrjälä
2018-10-29 23:00 ` [PATCH 5/5] drm/i915: Kill WA 0826 Rodrigo Vivi
2018-10-30 0:00 ` [PATCH] " Rodrigo Vivi
2018-10-30 18:38 ` Ville Syrjälä [this message]
2018-10-29 23:36 ` [PATCH 1/5] drm/i915: Remove CNL from WA 827 Clint Taylor
2018-10-29 23:58 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/5] " Patchwork
2018-10-30 0:16 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-30 1:00 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: Remove CNL from WA 827 (rev3) Patchwork
2018-10-30 1:17 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-30 8:35 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-30 22:54 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Remove CNL from WA 827 (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030183844.GG9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox