From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/icl: Fix DC9 Suspend for ICL.
Date: Thu, 1 Nov 2018 11:22:58 -0700 [thread overview]
Message-ID: <20181101182258.GD2092@intel.com> (raw)
In-Reply-To: <20181031211509.GJ2396@intel.com>
On Wed, Oct 31, 2018 at 02:15:09PM -0700, Rodrigo Vivi wrote:
> On Wed, Oct 31, 2018 at 01:27:26PM -0700, Anusha Srivatsa wrote:
>
> I intend to modify this commit message while merging with the following:
>
> Add missing block that takes care of inline intel_suspend_complete
> for DC9 on ICL.
>
> Daniele noticed this was part of original patch but missed on
> on merged commit ("drm/i915/icl: Enable DC9 as lowest possible
> state during screen-off").
>
> With this or something like this:
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> (But if my proposed message is not ok, please send a v2)
>
> > Fixes: 3e68928b7d4c ("drm/i915/icl: Enable DC9 as lowest possible state during screen-off")
> >
>
> ^ remove this empty line
added commit message while pushing.
pushed to dinq, thanks for the patch and for report.
>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Animesh Manna <animesh.manna@intel.com>
> > Cc: James Ausmus <james.ausmus@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 198d625f2871..acb516308262 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -1962,7 +1962,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation)
> > get_suspend_mode(dev_priv, hibernation));
> >
> > ret = 0;
> > - if (IS_GEN9_LP(dev_priv))
> > + if (INTEL_GEN(dev_priv) >= 11 || IS_GEN9_LP(dev_priv))
> > bxt_enable_dc9(dev_priv);
> > else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> > hsw_enable_pc8(dev_priv);
> > --
> > 2.17.1
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-01 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 20:27 [PATCH] drm/i915/icl: Fix DC9 Suspend for ICL Anusha Srivatsa
2018-10-31 21:15 ` Rodrigo Vivi
2018-11-01 18:22 ` Rodrigo Vivi [this message]
2018-10-31 21:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-01 6:56 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101182258.GD2092@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox