From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: [PATCH 04/12] kernel/lockdep: Make cross-release a config option
Date: Fri, 2 Nov 2018 10:15:23 +0100 [thread overview]
Message-ID: <20181102091531.7775-4-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20181102091531.7775-1-daniel.vetter@ffwll.ch>
cross-release annotations will need some serious amounts of vetting
before they can be enabled by default, or we'll just annoy everyone.
Instead split it into a separate option, which for now stays disabled
by default even if you enable overall lockdep.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Waiman Long <longman@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Yury Norov <ynorov@caviumnetworks.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
lib/Kconfig.debug | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index fbfdf7c263d2..7e504b7fbbe1 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1055,8 +1055,6 @@ config PROVE_LOCKING
select DEBUG_RWSEMS if RWSEM_SPIN_ON_OWNER
select DEBUG_WW_MUTEX_SLOWPATH
select DEBUG_LOCK_ALLOC
- select LOCKDEP_CROSSRELEASE
- select LOCKDEP_COMPLETIONS
select TRACE_IRQFLAGS
default n
help
@@ -1093,6 +1091,18 @@ config PROVE_LOCKING
For more details, see Documentation/locking/lockdep-design.txt.
+config LOCKDEP_CROSSRELEASE
+ bool "Enable cross-release checking"
+ depends on PROVE_LOCKING
+ select LOCKDEP_COMPLETIONS
+ help
+ This makes lockdep work for crosslock which is a lock allowed to
+ be released in a different context from the acquisition context.
+ Normally a lock must be released in the context acquiring the lock.
+ However, relexing this constraint helps synchronization primitives
+ such as page locks or completions can use the lock correctness
+ detector, lockdep.
+
config LOCK_STAT
bool "Lock usage statistics"
depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
@@ -1189,16 +1199,6 @@ config LOCKDEP
config LOCKDEP_SMALL
bool
-config LOCKDEP_CROSSRELEASE
- bool
- help
- This makes lockdep work for crosslock which is a lock allowed to
- be released in a different context from the acquisition context.
- Normally a lock must be released in the context acquiring the lock.
- However, relexing this constraint helps synchronization primitives
- such as page locks or completions can use the lock correctness
- detector, lockdep.
-
config LOCKDEP_COMPLETIONS
bool
help
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-02 9:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 9:15 [PATCH 01/12] locking/lockdep: restore cross-release checks Daniel Vetter
2018-11-02 9:15 ` [PATCH 02/12] kthread: finer-grained lockdep/cross-release completion Daniel Vetter
2018-11-02 9:15 ` [PATCH 03/12] lockdep: Remove GFP_NOLOCKDEP annotation Daniel Vetter
2018-11-02 9:15 ` Daniel Vetter [this message]
2018-11-02 9:15 ` [PATCH 05/12] mm: Check if mmu notifier callbacks are allowed to fail Daniel Vetter
2018-11-02 9:15 ` [PATCH 06/12] mm, notifier: Catch sleeping/blocking for !blockable Daniel Vetter
2018-11-02 9:15 ` [PATCH 07/12] mm, notifier: Add a lockdep map for invalidate_range_start Daniel Vetter
2018-11-02 9:15 ` [PATCH 08/12] dma-fence: cross-release annotations Daniel Vetter
2018-11-02 9:15 ` [PATCH 09/12] reservation: Annotate dma_fence waits Daniel Vetter
2018-11-02 9:15 ` [PATCH 10/12] drm/i915: " Daniel Vetter
2018-11-06 13:55 ` [PATCH] " Daniel Vetter
2018-11-06 16:48 ` kbuild test robot
2018-11-06 16:48 ` kbuild test robot
2018-11-02 9:15 ` [PATCH 11/12] drm/i915: annotate intel_atomic_commit_fence_wait Daniel Vetter
2018-11-02 9:15 ` [PATCH 12/12] HAX FOR CI: Enable cross-release Daniel Vetter
2018-11-02 9:43 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] locking/lockdep: restore cross-release checks Patchwork
2018-11-02 9:49 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-02 10:04 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-11-06 14:14 ` ✗ Fi.CI.BAT: failure for series starting with [01/12] locking/lockdep: restore cross-release checks (rev2) Patchwork
2018-11-06 15:05 ` [PATCH] locking/lockdep: restore cross-release checks Daniel Vetter
2018-11-06 15:50 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with locking/lockdep: restore cross-release checks (rev3) Patchwork
2018-11-06 15:56 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-07 9:14 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102091531.7775-4-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox