From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use appropriate integer types for flags
Date: Wed, 14 Nov 2018 12:58:55 -0000 [thread overview]
Message-ID: <20181114125855.23198.25105@emeril.freedesktop.org> (raw)
In-Reply-To: <20181114120806.694-1-lionel.g.landwerlin@intel.com>
== Series Details ==
Series: drm/i915: use appropriate integer types for flags
URL : https://patchwork.freedesktop.org/series/52481/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
04bef9eefcf0 drm/i915: use appropriate integer types for flags
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 085603287452 ("drm/i915: Compare user's 64b GTT offset even on 32b")'
#8:
- 085603287452fc ("drm/i915: Compare user's 64b GTT offset even on 32b")
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c58281056a8b ("drm/i915: Mark up GTT sizes as u64")'
#9:
- c58281056a8b26 ("drm/i915: Mark up GTT sizes as u64")
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 83b466b1dc5f ("drm/i915: Mark pin flags as u64")'
#10:
- 83b466b1dc5f0b ("drm/i915: Mark pin flags as u64")
-:32: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#32: FILE: include/uapi/drm/i915_drm.h:898:
+#define EXEC_OBJECT_NEEDS_FENCE (1ULL<<0)
^
-:33: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#33: FILE: include/uapi/drm/i915_drm.h:899:
+#define EXEC_OBJECT_NEEDS_GTT (1ULL<<1)
^
-:34: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#34: FILE: include/uapi/drm/i915_drm.h:900:
+#define EXEC_OBJECT_WRITE (1ULL<<2)
^
-:35: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#35: FILE: include/uapi/drm/i915_drm.h:901:
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1ULL<<3)
^
-:36: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#36: FILE: include/uapi/drm/i915_drm.h:902:
+#define EXEC_OBJECT_PINNED (1ULL<<4)
^
-:37: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#37: FILE: include/uapi/drm/i915_drm.h:903:
+#define EXEC_OBJECT_PAD_TO_SIZE (1ULL<<5)
^
-:46: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#46: FILE: include/uapi/drm/i915_drm.h:924:
+#define EXEC_OBJECT_ASYNC (1ULL<<6)
^
-:54: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#54: FILE: include/uapi/drm/i915_drm.h:931:
+#define EXEC_OBJECT_CAPTURE (1ULL<<7)
^
-:64: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#64: FILE: include/uapi/drm/i915_drm.h:949:
+#define I915_EXEC_FENCE_WAIT (1UL<<0)
^
-:65: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#65: FILE: include/uapi/drm/i915_drm.h:950:
+#define I915_EXEC_FENCE_SIGNAL (1UL<<1)
^
-:79: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#79: FILE: include/uapi/drm/i915_drm.h:975:
+#define I915_EXEC_RING_MASK (7ULL<<0)
^
-:80: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#80: FILE: include/uapi/drm/i915_drm.h:976:
+#define I915_EXEC_DEFAULT (0ULL<<0)
^
-:81: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#81: FILE: include/uapi/drm/i915_drm.h:977:
+#define I915_EXEC_RENDER (1ULL<<0)
^
-:82: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#82: FILE: include/uapi/drm/i915_drm.h:978:
+#define I915_EXEC_BSD (2ULL<<0)
^
-:83: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#83: FILE: include/uapi/drm/i915_drm.h:979:
+#define I915_EXEC_BLT (3ULL<<0)
^
-:84: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#84: FILE: include/uapi/drm/i915_drm.h:980:
+#define I915_EXEC_VEBOX (4ULL<<0)
^
-:96: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#96: FILE: include/uapi/drm/i915_drm.h:988:
+#define I915_EXEC_CONSTANTS_MASK ^I(3ULL<<6)$
-:96: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#96: FILE: include/uapi/drm/i915_drm.h:988:
+#define I915_EXEC_CONSTANTS_MASK (3ULL<<6)
^
-:97: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#97: FILE: include/uapi/drm/i915_drm.h:989:
+#define I915_EXEC_CONSTANTS_REL_GENERAL (0ULL<<6) /* default */
^
-:98: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#98: FILE: include/uapi/drm/i915_drm.h:990:
+#define I915_EXEC_CONSTANTS_ABSOLUTE ^I(1ULL<<6)$
-:98: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#98: FILE: include/uapi/drm/i915_drm.h:990:
+#define I915_EXEC_CONSTANTS_ABSOLUTE (1ULL<<6)
^
-:99: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#99: FILE: include/uapi/drm/i915_drm.h:991:
+#define I915_EXEC_CONSTANTS_REL_SURFACE (2ULL<<6) /* gen4/5 only */
^
-:107: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#107: FILE: include/uapi/drm/i915_drm.h:998:
+#define I915_EXEC_GEN7_SOL_RESET (1ULL<<8)
^
-:113: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#113: FILE: include/uapi/drm/i915_drm.h:1003:
+#define I915_EXEC_SECURE (1ULL<<9)
^
-:122: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#122: FILE: include/uapi/drm/i915_drm.h:1012:
+#define I915_EXEC_IS_PINNED (1ULL<<10)
^
-:130: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#130: FILE: include/uapi/drm/i915_drm.h:1019:
+#define I915_EXEC_NO_RELOC (1ULL<<11)
^
-:136: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#136: FILE: include/uapi/drm/i915_drm.h:1024:
+#define I915_EXEC_HANDLE_LUT (1ULL<<12)
^
-:154: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#154: FILE: include/uapi/drm/i915_drm.h:1037:
+#define I915_EXEC_RESOURCE_STREAMER (1ULL<<15)
^
-:163: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#163: FILE: include/uapi/drm/i915_drm.h:1045:
+#define I915_EXEC_FENCE_IN (1ULL<<16)
^
-:172: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#172: FILE: include/uapi/drm/i915_drm.h:1062:
+#define I915_EXEC_FENCE_OUT (1ULL<<17)
^
-:181: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#181: FILE: include/uapi/drm/i915_drm.h:1073:
+#define I915_EXEC_BATCH_FIRST (1ULL<<18)
^
-:188: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#188: FILE: include/uapi/drm/i915_drm.h:1079:
+#define I915_EXEC_FENCE_ARRAY (1ULL<<19)
^
-:199: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#199: FILE: include/uapi/drm/i915_drm.h:1355:
+#define I915_OVERLAY_UPDATE_ATTRS (1UL<<0)
^
-:200: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#200: FILE: include/uapi/drm/i915_drm.h:1356:
+#define I915_OVERLAY_UPDATE_GAMMA (1UL<<1)
^
-:201: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#201: FILE: include/uapi/drm/i915_drm.h:1357:
+#define I915_OVERLAY_DISABLE_DEST_COLORKEY (1UL<<2)
^
-:214: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#214: FILE: include/uapi/drm/i915_drm.h:1393:
+#define I915_SET_COLORKEY_NONE (1UL<<0) /* Deprecated. Instead set
^
-:215: ERROR:CODE_INDENT: code indent should use tabs where possible
#215: FILE: include/uapi/drm/i915_drm.h:1394:
+ * flags==0 to disable colorkeying.$
-:216: ERROR:CODE_INDENT: code indent should use tabs where possible
#216: FILE: include/uapi/drm/i915_drm.h:1395:
+ */$
-:217: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#217: FILE: include/uapi/drm/i915_drm.h:1396:
+#define I915_SET_COLORKEY_DESTINATION (1UL<<1)
^
-:218: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#218: FILE: include/uapi/drm/i915_drm.h:1397:
+#define I915_SET_COLORKEY_SOURCE (1UL<<2)
^
-:229: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#229: FILE: include/uapi/drm/i915_drm.h:1555:
+#define I915_PERF_FLAG_FD_CLOEXEC (1UL<<0)
^
-:230: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#230: FILE: include/uapi/drm/i915_drm.h:1556:
+#define I915_PERF_FLAG_FD_NONBLOCK (1UL<<1)
^
-:231: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#231: FILE: include/uapi/drm/i915_drm.h:1557:
+#define I915_PERF_FLAG_DISABLED (1UL<<2)
^
total: 5 errors, 2 warnings, 39 checks, 201 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-14 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 12:08 [PATCH] drm/i915: use appropriate integer types for flags Lionel Landwerlin
2018-11-14 12:41 ` Chris Wilson
2018-11-14 12:58 ` Patchwork [this message]
2018-11-14 13:22 ` Ville Syrjälä
2018-11-16 10:43 ` Lionel Landwerlin
2018-11-16 11:03 ` Ville Syrjälä
2018-11-14 14:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-11-14 20:53 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114125855.23198.25105@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox