From: Patchwork <patchwork@emeril.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
Date: Thu, 29 Nov 2018 13:51:55 -0000 [thread overview]
Message-ID: <20181129135155.5828.84383@emeril.freedesktop.org> (raw)
In-Reply-To: <20181129124247.11780-1-maarten.lankhorst@linux.intel.com>
== Series Details ==
Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
URL : https://patchwork.freedesktop.org/series/53239/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
65214d12d27f drm/i915/backlight: Restore backlight on resume
bbcaa34deb24 drm/i915/backlight: Fix backlight takeover on LPT, v2.
-:67: CHECK:BRACES: braces {} should be used on all arms of this statement
#67: FILE: drivers/gpu/drm/i915/intel_panel.c:1517:
+ if (cpu_mode) {
[...]
+ } else
[...]
-:81: WARNING:LONG_LINE: line over 100 characters
#81: FILE: drivers/gpu/drm/i915/intel_panel.c:1531:
+ val, freq, lpt_hz_to_pwm(connector, freq), panel->backlight.min, panel->backlight.max);
-:84: CHECK:BRACES: Unbalanced braces around else statement
#84: FILE: drivers/gpu/drm/i915/intel_panel.c:1534:
+ } else
total: 0 errors, 1 warnings, 2 checks, 62 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-29 13:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 12:42 [PATCH 1/2] drm/i915/backlight: Restore backlight on resume Maarten Lankhorst
2018-11-29 12:42 ` [PATCH 2/2] drm/i915/backlight: Fix backlight takeover on LPT, v2 Maarten Lankhorst
2018-11-29 12:51 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume Patchwork
2018-11-29 12:53 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-11-29 13:08 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-11-29 13:51 ` Patchwork [this message]
2018-11-29 13:53 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2) Patchwork
2018-11-29 14:08 ` ✓ Fi.CI.BAT: success " Patchwork
2018-11-30 1:21 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129135155.5828.84383@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox