Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915/ddi: Check for unexpectedly disabled transcoders
Date: Thu, 29 Nov 2018 17:40:51 +0200	[thread overview]
Message-ID: <20181129154051.21896-1-imre.deak@intel.com> (raw)

The DDI eDP/pipe A/B/C transcoders must be enabled whenever we observe
the DDI buffer of the port connected to them to be enabled (via
DDI_BUF_CTL). Add a consistency check for this to the HW readout code of
these transcoders.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index ad11540ac436..0476d1d33bfb 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2029,6 +2029,8 @@ static void intel_ddi_get_encoder_pipes(struct intel_encoder *encoder,
 	if (port == PORT_A) {
 		tmp = I915_READ(TRANS_DDI_FUNC_CTL(TRANSCODER_EDP));
 
+		WARN_ON(!(tmp & TRANS_DDI_FUNC_ENABLE));
+
 		switch (tmp & TRANS_DDI_EDP_INPUT_MASK) {
 		default:
 			MISSING_CASE(tmp & TRANS_DDI_EDP_INPUT_MASK);
@@ -2057,6 +2059,8 @@ static void intel_ddi_get_encoder_pipes(struct intel_encoder *encoder,
 		if ((tmp & TRANS_DDI_PORT_MASK) != TRANS_DDI_SELECT_PORT(port))
 			continue;
 
+		WARN_ON(!(tmp & TRANS_DDI_FUNC_ENABLE));
+
 		if ((tmp & TRANS_DDI_MODE_SELECT_MASK) ==
 		    TRANS_DDI_MODE_SELECT_DP_MST)
 			mst_pipe_mask |= BIT(p);
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2018-11-29 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 15:40 Imre Deak [this message]
2018-11-29 17:07 ` ✓ Fi.CI.BAT: success for drm/i915/ddi: Check for unexpectedly disabled transcoders Patchwork
2018-11-30  7:31 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-11-30 17:14   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129154051.21896-1-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox