From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Remove dead update_wm_pre assignment from SKL wm code
Date: Thu, 29 Nov 2018 22:30:37 -0800 [thread overview]
Message-ID: <20181130063037.GC5034@intel.com> (raw)
In-Reply-To: <20181113172330.26069-3-ville.syrjala@linux.intel.com>
On Tue, Nov 13, 2018 at 07:23:30PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> SKL+ do not use crtc_state->update_wm_pre, so there is absolutely no
> point it setting it. crtc_state->update_wm_pre only exists as a
> temporary hack for pre-g4x platforms until we redo their
> watermarks to be be atomic.
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5d823bdc63a9..9801412062cc 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5473,12 +5473,6 @@ skl_compute_wm(struct drm_atomic_state *state)
>
> if (changed)
> results->dirty_pipes |= drm_crtc_mask(crtc);
> -
> - if ((results->dirty_pipes & drm_crtc_mask(crtc)) == 0)
> - /* This pipe's WM's did not change */
> - continue;
> -
> - intel_cstate->update_wm_pre = true;
> }
>
> skl_print_wm_changes(state);
> --
> 2.18.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-30 6:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 17:23 [PATCH 1/3] drm/i915: Use explicit old crtc state in skl_compute_wm() Ville Syrjala
2018-11-13 17:23 ` [PATCH 2/3] drm/i915: Remove bogus FIXME from SKL wm computation Ville Syrjala
2018-11-30 6:28 ` Rodrigo Vivi
2018-11-13 17:23 ` [PATCH 3/3] drm/i915: Remove dead update_wm_pre assignment from SKL wm code Ville Syrjala
2018-11-30 6:30 ` Rodrigo Vivi [this message]
2018-12-07 18:47 ` Ville Syrjälä
2018-11-13 18:16 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Use explicit old crtc state in skl_compute_wm() Patchwork
2018-11-14 16:37 ` ✓ Fi.CI.IGT: " Patchwork
2018-11-30 6:27 ` [PATCH 1/3] " Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130063037.GC5034@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox