From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chunming Zhou <david1.zhou@amd.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] dma-buf: add new dma_fence_chain container v4
Date: Tue, 11 Dec 2018 11:18:29 -0000 [thread overview]
Message-ID: <20181211111829.9786.98883@emeril.freedesktop.org> (raw)
In-Reply-To: <20181211103449.25899-1-david1.zhou@amd.com>
== Series Details ==
Series: series starting with [01/10] dma-buf: add new dma_fence_chain container v4
URL : https://patchwork.freedesktop.org/series/53879/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
840d7cb7e1cc dma-buf: add new dma_fence_chain container v4
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12:
v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno,
-:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#31:
new file mode 100644
-:36: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#36: FILE: drivers/dma-buf/dma-fence-chain.c:1:
+/*
-:94: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#94: FILE: drivers/dma-buf/dma-fence-chain.c:59:
+ while ((prev = dma_fence_chain_get_prev(chain))) {
+
-:156: ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: drivers/dma-buf/dma-fence-chain.c:121:
+ return "dma_fence_chain";$
-:156: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: drivers/dma-buf/dma-fence-chain.c:121:
+ return "dma_fence_chain";$
-:161: ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: drivers/dma-buf/dma-fence-chain.c:126:
+ return "unbound";$
-:161: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: drivers/dma-buf/dma-fence-chain.c:126:
+ return "unbound";$
-:283: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#283: FILE: include/linux/dma-fence-chain.h:1:
+/*
-:318: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#318: FILE: include/linux/dma-fence-chain.h:36:
+ spinlock_t lock;
-:352: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#352: FILE: include/linux/dma-fence-chain.h:70:
+#define dma_fence_chain_for_each(iter, head) \
+ for (iter = dma_fence_get(head); iter; \
+ iter = dma_fence_chain_walk(head))
-:352: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'head' - possible side-effects?
#352: FILE: include/linux/dma-fence-chain.h:70:
+#define dma_fence_chain_for_each(iter, head) \
+ for (iter = dma_fence_get(head); iter; \
+ iter = dma_fence_chain_walk(head))
-:363: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'
total: 2 errors, 7 warnings, 4 checks, 328 lines checked
87065bf020ee drm/syncobj: remove drm_syncobj_cb and cleanup
-:77: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#77: FILE: drivers/gpu/drm/drm_syncobj.c:107:
+ wait->fence = dma_fence_get(
-:217: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'
total: 0 errors, 1 warnings, 1 checks, 186 lines checked
59a66b97c017 drm/syncobj: add new drm_syncobj_add_point interface v3
-:87: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'
total: 0 errors, 1 warnings, 0 checks, 60 lines checked
2b8a180d5fb2 drm/syncobj: add support for timeline point wait v8
-:11: WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'?
#11:
add seperate ioctl for timeline point wait, otherwise break uapi.
-:54: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#54: FILE: drivers/gpu/drm/drm_ioctl.c:679:
+ DRM_UNLOCKED|DRM_RENDER_ALLOW),
^
-:163: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!points"
#163: FILE: drivers/gpu/drm/drm_syncobj.c:680:
+ if (points == NULL)
-:324: CHECK:LINE_SPACING: Please don't use multiple blank lines
#324: FILE: drivers/gpu/drm/drm_syncobj.c:998:
+
+
-:356: CHECK:LINE_SPACING: Please don't use multiple blank lines
#356: FILE: include/uapi/drm/drm.h:763:
+
+
total: 0 errors, 1 warnings, 4 checks, 302 lines checked
baf631df82a6 drm/syncobj: add timeline payload query ioctl v4
-:44: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#44: FILE: drivers/gpu/drm/drm_ioctl.c:685:
+ DRM_UNLOCKED|DRM_RENDER_ALLOW),
^
-:114: CHECK:LINE_SPACING: Please don't use multiple blank lines
#114: FILE: include/uapi/drm/drm.h:777:
+
+
total: 0 errors, 0 warnings, 2 checks, 84 lines checked
910c349cf9d7 drm/syncobj: use the timeline point in drm_syncobj_find_fence v3
-:77: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Christian König <ckoenig.leichtzumerken@gmail.com>'
total: 0 errors, 1 warnings, 0 checks, 56 lines checked
0311d860d79e drm/amdgpu: add timeline support in amdgpu CS v2
-:43: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#43: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu.h:467:
+ unsigned num_post_deps;
-:121: CHECK:LINE_SPACING: Please don't use multiple blank lines
#121: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1146:
+
-:126: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#126: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1151:
+ unsigned num_deps;
-:168: CHECK:LINE_SPACING: Please don't use multiple blank lines
#168: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1187:
+
+
-:182: CHECK:LINE_SPACING: Please don't use multiple blank lines
#182: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1201:
+
+
-:188: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#188: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1207:
+ unsigned num_deps;
-:300: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: include/uapi/drm/amdgpu_drm.h:604:
+ __u32 handle;$
-:301: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: include/uapi/drm/amdgpu_drm.h:605:
+ __u32 flags;$
-:302: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: include/uapi/drm/amdgpu_drm.h:606:
+ __u64 point;$
total: 0 errors, 6 warnings, 3 checks, 266 lines checked
2dd3be4e6245 drm/syncobj: add transition iotcls between binary and timeline v2
-:35: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#35: FILE: drivers/gpu/drm/drm_ioctl.c:677:
+ DRM_UNLOCKED|DRM_RENDER_ALLOW),
^
-:56: WARNING:BRACES: braces {} are not necessary for single statement blocks
#56: FILE: drivers/gpu/drm/drm_syncobj.c:682:
+ if (!timeline_syncobj) {
+ return -ENOENT;
+ }
-:64: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*chain)...) over kzalloc(sizeof(struct dma_fence_chain)...)
#64: FILE: drivers/gpu/drm/drm_syncobj.c:690:
+ chain = kzalloc(sizeof(struct dma_fence_chain), GFP_KERNEL);
-:100: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#100: FILE: drivers/gpu/drm/drm_syncobj.c:726:
+}
+int
total: 0 errors, 1 warnings, 3 checks, 118 lines checked
0c1208ed2010 drm/syncobj: add timeline signal ioctl for syncobj v2
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6:
v2: individually allocate chain array, since chain node is free independently.
-:32: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#32: FILE: drivers/gpu/drm/drm_ioctl.c:687:
+ DRM_UNLOCKED|DRM_RENDER_ALLOW),
^
-:85: CHECK:LINE_SPACING: Please don't use multiple blank lines
#85: FILE: drivers/gpu/drm/drm_syncobj.c:1217:
+
+
-:96: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*chains[i])...) over kzalloc(sizeof(struct dma_fence_chain)...)
#96: FILE: drivers/gpu/drm/drm_syncobj.c:1228:
+ chains[i] = kzalloc(sizeof(struct dma_fence_chain), GFP_KERNEL);
-:106: CHECK:BRACES: braces {} should be used on all arms of this statement
#106: FILE: drivers/gpu/drm/drm_syncobj.c:1238:
+ if (points[i]) {
[...]
+ } else
[...]
-:112: CHECK:BRACES: Unbalanced braces around else statement
#112: FILE: drivers/gpu/drm/drm_syncobj.c:1244:
+ } else
total: 0 errors, 1 warnings, 5 checks, 110 lines checked
b2b237d605c5 drm/amdgpu: update version for timeline syncobj support in amdgpu
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 11 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-11 11:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 10:34 [PATCH 01/10] dma-buf: add new dma_fence_chain container v4 Chunming Zhou
2018-12-11 10:34 ` [PATCH 02/10] drm/syncobj: remove drm_syncobj_cb and cleanup Chunming Zhou
2018-12-11 10:34 ` [PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v3 Chunming Zhou
2018-12-11 10:34 ` [PATCH 04/10] drm/syncobj: add support for timeline point wait v8 Chunming Zhou
2018-12-11 10:34 ` [PATCH 05/10] drm/syncobj: add timeline payload query ioctl v4 Chunming Zhou
2018-12-11 10:34 ` [PATCH 06/10] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3 Chunming Zhou
2018-12-13 11:37 ` Chris Wilson
2018-12-13 12:11 ` [Intel-gfx] " Koenig, Christian
[not found] ` <36d34a20-2562-4265-9abc-4d3bd6d358ef-5C7GfCeVMHo@public.gmane.org>
2018-12-13 12:21 ` Chris Wilson
2018-12-13 12:24 ` Koenig, Christian
2018-12-13 16:01 ` Daniel Vetter
[not found] ` <20181213160148.GG21184-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-12-13 16:47 ` Koenig, Christian
2018-12-13 17:26 ` Daniel Vetter
2018-12-13 18:55 ` Koenig, Christian
[not found] ` <20181211103449.25899-1-david1.zhou-5C7GfCeVMHo@public.gmane.org>
2018-12-11 10:34 ` [PATCH 07/10] drm/amdgpu: add timeline support in amdgpu CS v2 Chunming Zhou
2018-12-11 10:34 ` [PATCH 08/10] drm/syncobj: add transition iotcls between binary and timeline v2 Chunming Zhou
2018-12-13 11:29 ` [Intel-gfx] [PATCH 01/10] dma-buf: add new dma_fence_chain container v4 Chris Wilson
2018-12-11 10:34 ` [PATCH 09/10] drm/syncobj: add timeline signal ioctl for syncobj v2 Chunming Zhou
2018-12-11 10:34 ` [PATCH 10/10] drm/amdgpu: update version for timeline syncobj support in amdgpu Chunming Zhou
2018-12-11 11:18 ` Patchwork [this message]
2018-12-11 11:24 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/10] dma-buf: add new dma_fence_chain container v4 Patchwork
2018-12-11 11:38 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-11 13:39 ` ✓ Fi.CI.IGT: " Patchwork
2018-12-12 5:31 ` [PATCH 01/10] " Zhou, David(ChunMing)
-- strict thread matches above, loose matches on Subject: below --
2018-12-07 15:54 Chunming Zhou
2018-12-07 16:27 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211111829.9786.98883@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=david1.zhou@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox