✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev8)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: Per context dynamic (sub)slice power-gating (rev8)
URL   : https://patchwork.freedesktop.org/series/48194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7bc81b868afe drm/i915/execlists: Move RPCS setup to context pin
5939874afc3d drm/i915: Record the sseu configuration per-context & engine
359b2f7b3643 drm/i915/perf: lock powergating configuration to default when active
db1043fd7760 drm/i915: Add timeline barrier support
62f6ae9d552a drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)
-:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#47: 
v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)

-:499: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->min_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#499: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

-:499: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->max_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#499: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

total: 0 errors, 1 warnings, 2 checks, 479 lines checked
393ecc46aec2 drm/i915/icl: Support co-existence between per-context SSEU and OA
b3cba63fa219 drm/i915/selftests: Context SSEU reconfiguration tests
-:222: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#222: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:784:
+int

-:402: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#402: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:964:
+			return -EINVAL;
+		} else {

-:409: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#409: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:971:
+
+}

total: 0 errors, 2 warnings, 1 checks, 563 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx