Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Clint Taylor <clinton.a.taylor@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
Date: Fri, 14 Dec 2018 14:15:59 -0800	[thread overview]
Message-ID: <20181214221559.GA31365@intel.com> (raw)
In-Reply-To: <819a4eed-ff02-5154-0549-d50462041bf9@intel.com>

On Fri, Dec 14, 2018 at 11:34:13AM -0800, Clint Taylor wrote:
>    Oops, failure caused by ICL_PORT_TX_DW7 not being defined yet. Still
>    waiting on r-b for a patch that includes the DW7 definition.

I believe it is easier to re-send both patches together. Specially
because apparently one justifies the other... Just preserve the authorship
and add your sign-off on the other patch and send as a series.

Thanks,
Rodrigo.

> 
>    -Clint
> 
>    On 12/14/18 10:15, Patchwork wrote:
> 
> == Series Details ==
> 
> Series: drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
> URL   : [1]https://patchwork.freedesktop.org/series/54069/
> State : failure
> 
> == Summary ==
> 
> CALL    scripts/checksyscalls.sh
>   DESCEND  objtool
>   CHK     include/generated/compile.h
>   CC [M]  drivers/gpu/drm/i915/icl_dsi.o
> In file included from drivers/gpu/drm/i915/intel_drv.h:33:0,
>                  from drivers/gpu/drm/i915/intel_dsi.h:30,
>                  from drivers/gpu/drm/i915/icl_dsi.c:30:
> drivers/gpu/drm/i915/icl_dsi.c: In function ‘dsi_program_swing_and_deemphasis’:
> drivers/gpu/drm/i915/icl_dsi.c:239:19: error: implicit declaration of function ‘
> ICL_PORT_TX_DW7_LN0’; did you mean ‘ICL_PORT_TX_DW4_LN0’? [-Werror=implicit-func
> tion-declaration]
>    tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
>                    ^
> drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ
> ’
>  #define I915_READ(reg)  dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
>                                                                       ^~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2
>  of ‘dev_priv->uncore.funcs.mmio_readl’
>  #define I915_READ(reg)  dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
>                                                                      ^
> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
>    tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
>          ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
>  #define I915_READ(reg)  dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
>                                                                      ^
> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
>    tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
>          ^~~~~~~~~
> drivers/gpu/drm/i915/icl_dsi.c:242:14: error: implicit declaration of function ‘
> ICL_PORT_TX_DW7_GRP’; did you mean ‘ICL_PORT_TX_DW5_GRP’? [-Werror=implicit-func
> tion-declaration]
>    I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
>               ^
> drivers/gpu/drm/i915/i915_drv.h:3439:76: note: in definition of macro ‘I915_WRIT
> E’
>  #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
>                                                                             ^~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2
>  of ‘dev_priv->uncore.funcs.mmio_writel’
>  #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
>                                                                            ^
> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
>    I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
>  #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
>                                                                            ^
> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
>    I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/icl_dsi.c:244:19: error: implicit declaration of function ‘
> ICL_PORT_TX_DW7_AUX’; did you mean ‘ICL_PORT_TX_DW2_AUX’? [-Werror=implicit-func
> tion-declaration]
>    tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
>                    ^
> drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ
> ’
>  #define I915_READ(reg)  dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
>                                                                       ^~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2
>  of ‘dev_priv->uncore.funcs.mmio_readl’
>  #define I915_READ(reg)  dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
>                                                                      ^
> drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
>    tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
>          ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
>  #define I915_READ(reg)  dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
>                                                                      ^
> drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
>    tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
>          ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2
>  of ‘dev_priv->uncore.funcs.mmio_writel’
>  #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
>                                                                            ^
> drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
>    I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
>    ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
>  #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
>                                                                            ^
> drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
>    I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
>    ^~~~~~~~~~
> cc1: all warnings being treated as errors
> scripts/Makefile.build:291: recipe for target 'drivers/gpu/drm/i915/icl_dsi.o' f
> ailed
> make[4]: *** [drivers/gpu/drm/i915/icl_dsi.o] Error 1
> scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm/i915' failed
> make[3]: *** [drivers/gpu/drm/i915] Error 2
> scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm' failed
> make[2]: *** [drivers/gpu/drm] Error 2
> scripts/Makefile.build:516: recipe for target 'drivers/gpu' failed
> make[1]: *** [drivers/gpu] Error 2
> Makefile:1060: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
> 
> References
> 
>    1. https://patchwork.freedesktop.org/series/54069/

> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-12-14 22:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 18:06 [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence clinton.a.taylor
2018-12-14 18:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-14 19:34   ` Clint Taylor
2018-12-14 22:15     ` Rodrigo Vivi [this message]
2018-12-15  2:58 ` [PATCH] " kbuild test robot
2018-12-16  2:33 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214221559.GA31365@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=clinton.a.taylor@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox