Re: [PATCH v2 2/4] drm/i915/bios: Parse the VBT TypeC and Thunderbolt port flags

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Dec 14, 2018 at 08:27:01PM +0200, Imre Deak wrote:
> This is needed by the next patch to determine if a DDI TypeC port is
> physically wired to a legacy DP or legacy HDMI connector or if the port
> is wired to a USB-C/Thunderbolt connector.
> 
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_drv.h   |  2 ++
>  drivers/gpu/drm/i915/intel_bios.c | 11 +++++++++--
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index e70707e79386..fd3cccaac89e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -935,6 +935,8 @@ struct ddi_vbt_port_info {
>  	uint8_t supports_hdmi:1;
>  	uint8_t supports_dp:1;
>  	uint8_t supports_edp:1;
> +	uint8_t supports_typec_usb:1;
> +	uint8_t supports_tbt:1;
>  
>  	uint8_t alternate_aux_channel;
>  	uint8_t alternate_ddc_pin;
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 6d3e0260d49c..e59a5af45e94 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1386,8 +1386,15 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv, enum port port,
>  	info->supports_dp = is_dp;
>  	info->supports_edp = is_edp;
>  
> -	DRM_DEBUG_KMS("Port %c VBT info: DP:%d HDMI:%d DVI:%d EDP:%d CRT:%d\n",
> -		      port_name(port), is_dp, is_hdmi, is_dvi, is_edp, is_crt);
> +	if (bdb_version >= 195)
> +	       info->supports_typec_usb = child->dp_usb_type_c;
> +
> +	if (bdb_version >= 209)
> +		info->supports_tbt = child->tbt;
> +
> +	DRM_DEBUG_KMS("Port %c VBT info: DP:%d HDMI:%d DVI:%d EDP:%d CRT:%d TCUSB:%d TBT:%d\n",
> +		      port_name(port), is_dp, is_hdmi, is_dvi, is_edp, is_crt,
> +		      info->supports_typec_usb, info->supports_tbt);
>  
>  	if (is_edp && is_dvi)
>  		DRM_DEBUG_KMS("Internal DP port %c is TMDS compatible\n",
> -- 
> 2.13.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx