From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Rodrigo Vivi <rodrigo.vivi@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v6 2/4] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC
Date: Mon, 7 Jan 2019 17:38:08 +0200 [thread overview]
Message-ID: <20190107153808.GP9170@smile.fi.intel.com> (raw)
In-Reply-To: <20190107111556.4510-3-hdegoede@redhat.com>
On Mon, Jan 07, 2019 at 12:15:54PM +0100, Hans de Goede wrote:
> Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove
> PMIC.
>
> On some CHT devices this fixes the LCD panel not lighting up when it was
> not initialized by the GOP, because an external monitor was plugged in and
> the GOP initialized only the external monitor.
> + if (i2c_client_address > 0xff || reg_address > 0xff) {
> + pr_warn("%s warning addresses too big client 0x%x reg 0x%x\n",
> + __func__, i2c_client_address, reg_address);
I tried to parse the message and failed.
Perhaps something like
"%s: addresses too big for client 0x%x, reg 0x%x\n"
would be easier to understand?
> + return -ERANGE;
> + }
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-07 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 11:15 [PATCH v6 0/4] ACPI/i915: Add support for PMIC MIPI sequence elements Hans de Goede
2019-01-07 11:15 ` [PATCH v6 1/4] ACPI / PMIC: Add support for executing " Hans de Goede
2019-01-07 15:35 ` Andy Shevchenko
2019-01-08 13:40 ` Hans de Goede
2019-01-07 11:15 ` [PATCH v6 2/4] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC Hans de Goede
2019-01-07 15:38 ` Andy Shevchenko [this message]
2019-01-07 11:15 ` [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling Hans de Goede
2019-01-07 15:31 ` Ville Syrjälä
2019-01-07 15:46 ` Andy Shevchenko
2019-01-08 13:45 ` Hans de Goede
2019-01-08 14:51 ` Andy Shevchenko
2019-01-08 15:35 ` Hans de Goede
2019-01-08 17:33 ` Andy Shevchenko
2019-01-09 9:26 ` Hans de Goede
2019-01-07 11:15 ` [PATCH v6 4/4] drm/i915/intel_dsi_vbt: Add support for PMIC MIPI sequences Hans de Goede
2019-01-07 15:31 ` Ville Syrjälä
2019-01-09 9:40 ` Hans de Goede
2019-01-07 12:47 ` ✓ Fi.CI.BAT: success for ACPI/i915: Add support for PMIC MIPI sequence elements (rev2) Patchwork
2019-01-07 16:19 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107153808.GP9170@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox