✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev4)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev4)
Date: Tue, 08 Jan 2019 10:23:02 -0000	[thread overview]
Message-ID: <20190108102302.28502.64747@emeril.freedesktop.org> (raw)
In-Reply-To: <1546938687-27306-1-git-send-email-uma.shankar@intel.com>

== Series Details ==

Series: Add HDR Metadata Parsing and handling in DRM layer (rev4)
URL   : https://patchwork.freedesktop.org/series/25091/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a9de93ef72da drm: Add HDR source metadata property
5c3a79ebc262 drm: Parse HDR metadata info from EDID
-:72: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#72: FILE: drivers/gpu/drm/drm_edid.c:3825:
+{
+

-:78: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#78: FILE: drivers/gpu/drm/drm_edid.c:3831:
+
+}

-:82: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#82: FILE: drivers/gpu/drm/drm_edid.c:3835:
+{
+

total: 0 errors, 0 warnings, 3 checks, 84 lines checked
21659c91b7d7 drm: Parse Colorimetry data block from EDID
-:58: CHECK:LINE_SPACING: Please don't use multiple blank lines
#58: FILE: drivers/gpu/drm/drm_edid.c:3835:
+
+

total: 0 errors, 0 warnings, 1 checks, 53 lines checked
7bfd3f274d32 drm/i915: Attach HDR metadata property to connector
-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/gpu/drm/i915/intel_hdmi.c:2158:
+	drm_object_attach_property(&connector->base,
+		connector->dev->mode_config.hdr_output_metadata_property, 0);

total: 0 errors, 0 warnings, 1 checks, 8 lines checked
192d03978105 drm: Add HDR capability field to plane structure
-:26: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#26: FILE: include/drm/drm_plane.h:642:
+	bool hdr_supported;

total: 0 errors, 0 warnings, 1 checks, 9 lines checked
9fbc812a7704 drm: Implement HDR output metadata set and get property handling
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/gpu/drm/drm_atomic_uapi.c:741:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+				&state->hdr_output_metadata_blob_ptr,

total: 0 errors, 0 warnings, 1 checks, 39 lines checked
74ce2de050b0 drm: Enable HDR infoframe support
-:63: CHECK:LINE_SPACING: Please don't use multiple blank lines
#63: FILE: drivers/gpu/drm/drm_edid.c:4939:
+
+

-:92: CHECK:LINE_SPACING: Please don't use multiple blank lines
#92: FILE: drivers/gpu/drm/drm_edid.c:4968:
+
+

-:230: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#230: FILE: drivers/video/hdmi.c:1392:
+	hdmi_infoframe_log_header(level, dev,
+			(struct hdmi_any_infoframe *)frame);

-:243: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#243: FILE: drivers/video/hdmi.c:1405:
+	hdmi_log("max_mastering_display_luminance: %d\n",
+			frame->max_mastering_display_luminance);

-:245: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#245: FILE: drivers/video/hdmi.c:1407:
+	hdmi_log("min_mastering_display_luminance: %d\n",
+			frame->min_mastering_display_luminance);

total: 0 errors, 0 warnings, 5 checks, 279 lines checked
2f3a29eaef1d drm/i915: Write HDR infoframe and send to panel
aab65b38b757 drm/i915: [DO NOT MERGE] hack for glk board outputs
a66c7b9c2cf9 drm/i915: Add HLG EOTF
6b58f31b5eb4 drm/i915: Enable infoframes on GLK+ for HDR
-:49: WARNING:LONG_LINE: line over 100 characters
#49: FILE: drivers/gpu/drm/i915/i915_reg.h:8082:
+#define GLK_TVIDEO_DIP_DRM_DATA(trans, i)	_MMIO_TRANS2(trans, _GLK_VIDEO_DIP_DRM_DATA_A + (i) * 4)

-:101: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#101: FILE: drivers/gpu/drm/i915/intel_hdmi.c:919:
+	if ((INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) &&
+		conn_state->hdr_metadata_changed)

total: 0 errors, 1 warnings, 1 checks, 71 lines checked
552a34db0d65 drm/i915:Enabled Modeset when HDR Infoframe changes
-:57: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#57: FILE: drivers/gpu/drm/i915/intel_hdmi.c:495:
+	if (!conn_state->hdr_output_metadata_blob_ptr ||
+		conn_state->hdr_output_metadata_blob_ptr->length == 0)

total: 0 errors, 0 warnings, 1 checks, 37 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx