✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev11)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: Per context dynamic (sub)slice power-gating (rev11)
URL   : https://patchwork.freedesktop.org/series/48194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3350b5e6ed18 drm/i915/execlists: Move RPCS setup to context pin
961bc57575da drm/i915: Record the sseu configuration per-context & engine
37c8e6fcbba7 drm/i915/perf: lock powergating configuration to default when active
-:72: WARNING:BAD_SIGN_OFF: 'Co-developed-by:' is the preferred signature form
#72: 
Co-Developed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

total: 0 errors, 1 warnings, 0 checks, 126 lines checked
f2b12bcf0ca7 drm/i915: Add timeline barrier support
d9a1551457de drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)
-:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#47: 
v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)

-:506: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->min_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#506: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

-:506: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->max_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#506: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

total: 0 errors, 1 warnings, 2 checks, 479 lines checked
93a3f1fd397c drm/i915/selftests: Context SSEU reconfiguration tests
-:407: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#407: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:961:
+			return -EINVAL;
+		} else {

-:414: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#414: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:968:
+
+}

total: 0 errors, 1 warnings, 1 checks, 550 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx