Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev14)
Date: Mon, 14 Jan 2019 14:13:13 -0000	[thread overview]
Message-ID: <20190114141313.24567.87956@emeril.freedesktop.org> (raw)
In-Reply-To: <20190114135727.14851-1-tvrtko.ursulin@linux.intel.com>

== Series Details ==

Series: Per context dynamic (sub)slice power-gating (rev14)
URL   : https://patchwork.freedesktop.org/series/48194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bef4bdb66bef drm/i915/execlists: Move RPCS setup to context pin
495ee6ca200b drm/i915: Record the sseu configuration per-context & engine
3373d3f03cfa drm/i915/perf: lock powergating configuration to default when active
-:72: WARNING:BAD_SIGN_OFF: 'Co-developed-by:' is the preferred signature form
#72: 
Co-Developed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

total: 0 errors, 1 warnings, 0 checks, 126 lines checked
b001897e9125 drm/i915: Add timeline barrier support
33d1f7fa0b1d drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)
-:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#47: 
v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)

-:514: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->min_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#514: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1170:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

-:514: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->max_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#514: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1170:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

total: 0 errors, 1 warnings, 2 checks, 500 lines checked
eaf5cc16f8e9 drm/i915/selftests: Context SSEU reconfiguration tests
-:407: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#407: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:961:
+			return -EINVAL;
+		} else {

-:414: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#414: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:968:
+
+}

total: 0 errors, 1 warnings, 1 checks, 550 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-01-14 14:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 13:57 [PATCH 0/6] Per context dynamic (sub)slice power-gating Tvrtko Ursulin
2019-01-14 13:57 ` [PATCH 1/6] drm/i915/execlists: Move RPCS setup to context pin Tvrtko Ursulin
2019-01-14 13:57 ` [PATCH 2/6] drm/i915: Record the sseu configuration per-context & engine Tvrtko Ursulin
2019-01-14 13:57 ` [PATCH 3/6] drm/i915/perf: lock powergating configuration to default when active Tvrtko Ursulin
2019-01-14 13:57 ` [PATCH 4/6] drm/i915: Add timeline barrier support Tvrtko Ursulin
2019-01-14 13:57 ` [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only) Tvrtko Ursulin
2019-01-14 13:57 ` [PATCH 6/6] drm/i915/selftests: Context SSEU reconfiguration tests Tvrtko Ursulin
2019-01-14 14:13 ` Patchwork [this message]
2019-01-14 14:15 ` ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev14) Patchwork
2019-01-14 14:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-14 19:40 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114141313.24567.87956@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox