From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/audio: Track temporary rpm wakerefs
Date: Mon, 14 Jan 2019 18:21:33 -0000 [thread overview]
Message-ID: <20190114182133.24567.17044@emeril.freedesktop.org> (raw)
In-Reply-To: <20190114173753.472-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: series starting with [1/3] drm/i915/audio: Track temporary rpm wakerefs
URL : https://patchwork.freedesktop.org/series/55194/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b531f8b4dca8 drm/i915/audio: Track temporary rpm wakerefs
c78a3bd63af7 snd/hda: Track the display_power_status using a cookie
-:57: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#57: FILE: include/drm/drm_audio_component.h:25:
+ unsigned long (*get_power)(struct device *);
-:64: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#64: FILE: include/drm/drm_audio_component.h:31:
+ void (*put_power)(struct device *, unsigned long);
-:64: WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned long' should also have an identifier name
#64: FILE: include/drm/drm_audio_component.h:31:
+ void (*put_power)(struct device *, unsigned long);
total: 0 errors, 3 warnings, 0 checks, 87 lines checked
b285256865f3 snd/hda: Protect concurrent display_power_status with a mutex
-:21: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#21: FILE: include/sound/hdaudio.h:371:
+ struct mutex display_power_lock;
total: 0 errors, 0 warnings, 1 checks, 38 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-14 18:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 17:37 [PATCH 1/3] drm/i915/audio: Track temporary rpm wakerefs Chris Wilson
2019-01-14 17:37 ` [PATCH 2/3] snd/hda: Track the display_power_status using a cookie Chris Wilson
2019-01-14 17:54 ` Takashi Iwai
2019-01-14 21:11 ` Chris Wilson
2019-01-14 17:37 ` [PATCH 3/3] snd/hda: Protect concurrent display_power_status with a mutex Chris Wilson
2019-01-14 17:46 ` Takashi Iwai
2019-01-14 17:51 ` Chris Wilson
2019-01-14 18:00 ` Takashi Iwai
2019-01-14 20:57 ` Chris Wilson
2019-01-14 21:18 ` Takashi Iwai
2019-01-14 18:07 ` [PATCH 1/3] drm/i915/audio: Track temporary rpm wakerefs John Harrison
2019-01-14 18:21 ` Patchwork [this message]
2019-01-14 19:14 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2019-01-15 0:29 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114182133.24567.17044@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox