From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix ILK-IVB primary plane enable delays
Date: Mon, 14 Jan 2019 21:39:52 +0200 [thread overview]
Message-ID: <20190114193952.GG20097@intel.com> (raw)
In-Reply-To: <1545305168-6047-1-git-send-email-juhapekka.heikkila@gmail.com>
On Thu, Dec 20, 2018 at 01:26:08PM +0200, Juha-Pekka Heikkila wrote:
> Primary and sprite plane enable on ILK-IVB may take two frames to complete
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103925
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 3b70948..b46ab48 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10813,8 +10813,11 @@ int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_crtc_stat
> * Despite the w/a only being listed for IVB we assume that
> * the ILK/SNB note has similar ramifications, hence we apply
> * the w/a on all three platforms.
> + *
> + * With experimental results seems this is needed also for primary
> + * plane, not only sprite plane.
Actually even documented in the spec. I wasn't able to reproduce this
myself for whatever reason while I was coming up with a cleaner way to
handle this. But let's trust the spec and go with it. My cleanup thing
isn't quite ready yet so I've landed your patch in the meantime. Thanks.
> */
> - if (plane->id == PLANE_SPRITE0 &&
> + if (plane->id != PLANE_CURSOR &&
> (IS_GEN_RANGE(dev_priv, 5, 6) ||
> IS_IVYBRIDGE(dev_priv)) &&
> (turn_on || (!needs_scaling(old_plane_state) &&
> --
> 2.7.4
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-01-14 19:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 11:26 [PATCH] drm/i915: Fix ILK-IVB primary plane enable delays Juha-Pekka Heikkila
2018-12-20 12:06 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-20 13:43 ` ✓ Fi.CI.BAT: success for drm/i915: Fix ILK-IVB primary plane enable delays (rev2) Patchwork
2018-12-21 12:58 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-14 19:39 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114193952.GG20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox