From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: rename has_edp_a() to intel_pch_has_edp_a()
Date: Mon, 21 Jan 2019 21:36:15 +0200 [thread overview]
Message-ID: <20190121193615.GU20097@intel.com> (raw)
In-Reply-To: <20190121142134.17434-5-jani.nikula@intel.com>
On Mon, Jan 21, 2019 at 04:21:34PM +0200, Jani Nikula wrote:
> Clarify that the name is specific to PCH platforms.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 6960004fdc94..32270d7b71b9 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14231,7 +14231,7 @@ static int intel_encoder_clones(struct intel_encoder *encoder)
> return index_mask;
> }
>
> -static bool has_edp_a(struct drm_i915_private *dev_priv)
> +static bool intel_pch_has_edp_a(struct drm_i915_private *dev_priv)
Hmm. The port is on the CPU though. The function name reads more like
it's looking for port A on the PCH now. ilk_has_edp_a() maybe?
> {
> if (!IS_MOBILE(dev_priv))
> return false;
> @@ -14385,7 +14385,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>
> dpd_is_edp = intel_dp_is_port_edp(dev_priv, PORT_D);
>
> - if (has_edp_a(dev_priv))
> + if (intel_pch_has_edp_a(dev_priv))
> intel_dp_init(dev_priv, DP_A, PORT_A);
>
> if (I915_READ(PCH_HDMIB) & SDVO_DETECTED) {
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-21 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 14:21 [PATCH 1/5] drm/i915/crt: split out intel_crt_present() to platform specific setup Jani Nikula
2019-01-21 14:21 ` [PATCH 2/5] drm/i915/lvds: only call intel_lvds_init() on platforms that might have LVDS Jani Nikula
2019-01-21 19:30 ` Ville Syrjälä
2019-01-21 14:21 ` [PATCH 3/5] drm/i915/lvds: nuke intel_lvds_supported() Jani Nikula
2019-01-21 19:31 ` Ville Syrjälä
2019-01-22 8:23 ` Jani Nikula
2019-01-21 14:21 ` [PATCH 4/5] drm/i915/tv: only call intel_tv_init() on platforms that might have TV Jani Nikula
2019-01-21 19:33 ` Ville Syrjälä
2019-01-22 8:25 ` Jani Nikula
2019-01-21 14:21 ` [PATCH 5/5] drm/i915: rename has_edp_a() to intel_pch_has_edp_a() Jani Nikula
2019-01-21 19:36 ` Ville Syrjälä [this message]
2019-01-21 15:39 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/crt: split out intel_crt_present() to platform specific setup Patchwork
2019-01-21 19:03 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-21 19:30 ` [PATCH 1/5] " Ville Syrjälä
2019-01-22 8:26 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121193615.GU20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox