From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix skl srckey mask bits
Date: Tue, 29 Jan 2019 16:33:15 +0200 [thread overview]
Message-ID: <20190129143315.GZ20097@intel.com> (raw)
In-Reply-To: <20190125215447.GZ4563@mdroper-desk.amr.corp.intel.com>
On Fri, Jan 25, 2019 at 01:54:47PM -0800, Matt Roper wrote:
> On Fri, Jan 25, 2019 at 08:38:46PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We're incorrectly masking off the R/V channel enable bit from
> > KEYMSK. Fix it up.
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Fixes: b20815255693 ("drm/i915: Add plane alpha blending support, v2.")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The "srckey" terminology in the headline is a bit confusing since the
> channel mask applies to both "destination colorkey" and "source
> colorkey" behavior.
Does it? IIRC it used to be only for source keying. I guess I'll have to
try it for reals.
> Otherwise,
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>
> Out of curiousity, has there ever been a userspace consumer of source
> colorkey? I know SNA uses destination colorkey (for Xv), but not source
> colorkey. And afaik, UXA never did any colorkeying through the sprite
> interface at all.
No, I don't think we have any userspace for this.
>
>
> Matt
>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index b02d3d9809e3..cd42e81f8a90 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -493,7 +493,7 @@ skl_program_plane(struct intel_plane *plane,
> >
> > keymax = (key->max_value & 0xffffff) | PLANE_KEYMAX_ALPHA(alpha);
> >
> > - keymsk = key->channel_mask & 0x3ffffff;
> > + keymsk = key->channel_mask & 0x7ffffff;
> > if (alpha < 0xff)
> > keymsk |= PLANE_KEYMSK_ALPHA_ENABLE;
> >
> > --
> > 2.19.2
> >
>
> --
> Matt Roper
> Graphics Software Engineer
> IoTG Platform Enabling & Development
> Intel Corporation
> (916) 356-2795
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-29 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 18:38 [PATCH] drm/i915: Fix skl srckey mask bits Ville Syrjala
2019-01-25 19:40 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-25 21:54 ` [PATCH] " Matt Roper
2019-01-29 14:33 ` Ville Syrjälä [this message]
2019-01-29 14:49 ` Ville Syrjälä
2019-01-29 16:57 ` Ville Syrjälä
2019-01-30 18:25 ` Matt Roper
2019-01-30 19:20 ` Ville Syrjälä
2019-01-25 23:30 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129143315.GZ20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox