public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Add Colorspace connector property interface (rev9)
Date: Tue, 29 Jan 2019 18:50:09 -0000	[thread overview]
Message-ID: <20190129185009.5283.31852@emeril.freedesktop.org> (raw)
In-Reply-To: <1548787812-13523-1-git-send-email-uma.shankar@intel.com>

== Series Details ==

Series: Add Colorspace connector property interface (rev9)
URL   : https://patchwork.freedesktop.org/series/47132/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2966dae600a0 drm: Add HDMI colorspace property
-:159: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#159: FILE: drivers/gpu/drm/drm_connector.c:1607:
+	if (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+			connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {

-:160: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#160: FILE: drivers/gpu/drm/drm_connector.c:1608:
+			connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) {
+

total: 0 errors, 0 warnings, 2 checks, 171 lines checked
058bb0ff8389 drm: Add DP colorspace property
-:60: CHECK:LINE_SPACING: Please don't use multiple blank lines
#60: FILE: drivers/gpu/drm/drm_connector.c:875:
+
+

-:70: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#70: FILE: drivers/gpu/drm/drm_connector.c:1640:
+		connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
+

total: 0 errors, 0 warnings, 2 checks, 43 lines checked
7510be7c09f5 drm/i915: Attach colorspace property and enable modeset
-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/i915/intel_connector.c:274:
+		drm_object_attach_property(&connector->base,
+		connector->colorspace_property, 0);

total: 0 errors, 0 warnings, 1 checks, 66 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-01-29 18:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 18:50 [v9 0/3] Add Colorspace connector property interface Uma Shankar
2019-01-29 18:50 ` Patchwork [this message]
2019-01-29 18:50 ` [v9 1/3] drm: Add HDMI colorspace property Uma Shankar
2019-01-29 18:50 ` [v9 2/3] drm: Add DP " Uma Shankar
2019-01-29 18:50 ` [v9 3/3] drm/i915: Attach colorspace property and enable modeset Uma Shankar
2019-01-30  9:57   ` Maarten Lankhorst
2019-01-30 12:29     ` Shankar, Uma
2019-01-29 18:52 ` ✗ Fi.CI.SPARSE: warning for Add Colorspace connector property interface (rev9) Patchwork
2019-01-29 19:17 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-29 21:23 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129185009.5283.31852@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox