Re: [Intel-gfx] [PATCH] drm: Constify drm_color_lut_check()

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Jan 29, 2019 at 07:58:56PM +0200, Ville Syrjälä wrote:
> On Tue, Jan 29, 2019 at 06:52:51PM +0100, Sam Ravnborg wrote:
> > Hi Ville.
> > 
> > On Tue, Jan 29, 2019 at 07:06:09PM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > drm_color_lut_check() doens't modify the passed in blob so
> > > let's make it const.
> > > 
> > > Also s/uint32_y/u32/ while at it.
> > > 
> > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > >  drivers/gpu/drm/drm_color_mgmt.c | 6 +++---
> > >  include/drm/drm_color_mgmt.h     | 4 ++--
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> > > index 968ca7c91ad8..3c8826a91a03 100644
> > > --- a/drivers/gpu/drm/drm_color_mgmt.c
> > > +++ b/drivers/gpu/drm/drm_color_mgmt.c
> > > @@ -474,10 +474,10 @@ EXPORT_SYMBOL(drm_plane_create_color_properties);
> > >   *
> > >   * Returns 0 on success, -EINVAL on failure.
> > >   */
> > > -int drm_color_lut_check(struct drm_property_blob *lut,
> > > -			uint32_t tests)
> > > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > > +			u32 tests)
> > 
> > No need to linewrap this line.
> > >  {
> > > -	struct drm_color_lut *entry;
> > > +	const struct drm_color_lut *entry;
> > >  	int i;
> > >  
> > >  	if (!lut || !tests)
> > > diff --git a/include/drm/drm_color_mgmt.h b/include/drm/drm_color_mgmt.h
> > > index 6affbda6d9cb..58d4b20b5b97 100644
> > > --- a/include/drm/drm_color_mgmt.h
> > > +++ b/include/drm/drm_color_mgmt.h
> > > @@ -96,6 +96,6 @@ enum drm_color_lut_tests {
> > >  	DRM_COLOR_LUT_NON_DECREASING = BIT(1),
> > >  };
> > >  
> > > -int drm_color_lut_check(struct drm_property_blob *lut,
> > > -			uint32_t tests);
> > > +int drm_color_lut_check(const struct drm_property_blob *lut,
> > > +			u32 tests);
> > Likewise.
> > 
> > With the linewrap fixed:
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> 
> Thanks.
> 
> > 
> > Note: does not apply to my drm-misc tree. Anything I miss here?
> 
> I think it was merged via drm-intel.

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

for merging through drm-intel then (assuming it goes in before the merge
cutoff), with Sam's suggestions ofc.
-Daniel

> 
> -- 
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel