From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915: Remove the intel_engine_notify tracepoint
Date: Tue, 29 Jan 2019 21:12:58 -0000 [thread overview]
Message-ID: <20190129211258.5283.45358@emeril.freedesktop.org> (raw)
In-Reply-To: <20190129205230.19056-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: series starting with [CI,1/3] drm/i915: Remove the intel_engine_notify tracepoint
URL : https://patchwork.freedesktop.org/series/55939/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8f31dfb2f578 drm/i915: Remove the intel_engine_notify tracepoint
025c1ce0fd8f drm/i915: Replace global breadcrumbs with per-context interrupt tracking
-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")'
#18:
Before commit 688e6c725816, the solution was simple. Every client
-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")'
#21:
688e6c725816 introduced an rbtree so that only the earliest waiter on
-:56: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56:
References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")
-:56: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")'
#56:
References: 688e6c725816 ("drm/i915: Slaughter the thundering i915_wait_request herd")
-:2178: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct i915_gem_context *' should also have an identifier name
#2178: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258:
+ struct i915_request *(*request_alloc)(struct i915_gem_context *,
-:2178: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_engine_cs *' should also have an identifier name
#2178: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:258:
+ struct i915_request *(*request_alloc)(struct i915_gem_context *,
-:2204: WARNING:LINE_SPACING: Missing a blank line after declarations
#2204: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:284:
+ struct i915_request **requests;
+ I915_RND_STATE(prng);
-:2636: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#2636:
deleted file mode 100644
total: 3 errors, 5 warnings, 0 checks, 2570 lines checked
eb1a54866d4d drm/i915: Drop fake breadcrumb irq
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-29 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 20:52 [CI 1/3] drm/i915: Remove the intel_engine_notify tracepoint Chris Wilson
2019-01-29 20:52 ` [CI 2/3] drm/i915: Replace global breadcrumbs with per-context interrupt tracking Chris Wilson
2019-01-29 20:52 ` [CI 3/3] drm/i915: Drop fake breadcrumb irq Chris Wilson
2019-01-29 21:12 ` Patchwork [this message]
2019-01-29 21:14 ` ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/3] drm/i915: Remove the intel_engine_notify tracepoint Patchwork
2019-01-29 21:31 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-30 0:53 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129211258.5283.45358@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox