From: Daniel Vetter <daniel@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Ramalingam C <ramalingm.c@intel.com>
Subject: Re: [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates
Date: Fri, 1 Feb 2019 16:07:16 +0100 [thread overview]
Message-ID: <20190201150716.GA3271@phenom.ffwll.local> (raw)
In-Reply-To: <20190201145519.12228-1-daniel.vetter@ffwll.ch>
On Fri, Feb 01, 2019 at 03:55:19PM +0100, Daniel Vetter wrote:
> ->mode_changed will be eaten by fastset, which is now enabled by
> default on at least some platforms. Once we have modeset-less hdcp, we
> need to go back to ->mode_changed (or maybe directly setting
> ->update_pipe) to avoid the modeset.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ramalingam C <ramalingm.c@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
I think this was broken by the patch to enable fastset everywhere:
Fixes: d19f958db23c ("drm/i915: Enable fastset for non-boot modesets.")
But we also don't have any hdcp tests in CI, because the shard runs don't
have hdcp capable outputs :-/
-Daniel
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index ce7ba3a9c000..7da25a7bfccb 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -864,7 +864,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,
>
> crtc_state = drm_atomic_get_new_crtc_state(new_state->state,
> new_state->crtc);
> - crtc_state->mode_changed = true;
> + crtc_state->connectors_changed = true;
> }
>
> /* Implements Part 3 of the HDCP authorization procedure */
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-01 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 14:55 [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates Daniel Vetter
2019-02-01 15:07 ` Daniel Vetter [this message]
2019-02-01 15:14 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-02-01 16:09 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-01 17:03 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201150716.GA3271@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingm.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox