public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sean Paul <sean@poorly.run>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: David1.Zhou@amd.com, oleksandr_andrushchenko@epam.com,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
	airlied@redhat.com, christian.koenig@amd.com
Subject: Re: [PATCH 4/6] drm/udl: Use drm_dev_unregister()
Date: Thu, 7 Feb 2019 16:07:52 -0500	[thread overview]
Message-ID: <20190207210752.GF114153@art_vandelay> (raw)
In-Reply-To: <20190203154200.61479-5-noralf@tronnes.org>

On Sun, Feb 03, 2019 at 04:41:58PM +0100, Noralf Trønnes wrote:
> drm_dev_unplug() has been stripped down and is going away. Open code its
> 2 remaining function calls.
> 
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Sean Paul <sean@poorly.run>

Reviewed-by: Sean Paul <sean@poorly.run>

> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
>  drivers/gpu/drm/udl/udl_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index 22cd2d13e272..063e8e1e2641 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -106,7 +106,8 @@ static void udl_usb_disconnect(struct usb_interface *interface)
>  	drm_kms_helper_poll_disable(dev);
>  	udl_fbdev_unplug(dev);
>  	udl_drop_usb(dev);
> -	drm_dev_unplug(dev);
> +	drm_dev_unregister(dev);
> +	drm_dev_put(dev);
>  }
>  
>  /*
> -- 
> 2.20.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-02-07 21:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03 15:41 [PATCH 0/6] drm/drv: Remove drm_dev_unplug() Noralf Trønnes
2019-02-03 15:41 ` [PATCH 1/6] drm: Fix drm_release() and device unplug Noralf Trønnes
     [not found]   ` <20190203154200.61479-2-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-02-04 10:17     ` Oleksandr Andrushchenko
2019-02-07 21:00     ` Sean Paul
2019-02-03 15:41 ` [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug() Noralf Trønnes
     [not found]   ` <20190203154200.61479-3-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-02-04 10:19     ` Oleksandr Andrushchenko
2019-02-04 15:41     ` [Intel-gfx] " Daniel Vetter
     [not found]       ` <20190204154153.GT3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-02-04 17:35         ` Noralf Trønnes
     [not found]           ` <fd6ab7d7-2f50-14bb-07f4-b25c9fe0892e-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-02-05  9:11             ` Daniel Vetter
     [not found]               ` <20190205091118.GC3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-02-05 10:20                 ` Noralf Trønnes
2019-02-05 16:31                   ` Daniel Vetter
     [not found]                     ` <20190205163144.GF3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-02-05 17:57                       ` Noralf Trønnes
2019-02-06 15:26                         ` Daniel Vetter
     [not found]                           ` <20190206152626.GI3271-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2019-02-06 16:46                             ` [Intel-gfx] " Noralf Trønnes
2019-02-06 20:36                               ` Daniel Vetter
2019-02-06 18:10                             ` [Intel-gfx] " Eric Anholt
2019-02-07 21:07     ` Sean Paul
2019-02-07 21:52       ` Sean Paul
2019-02-03 15:41 ` [PATCH 3/6] drm/amd: Use drm_dev_unregister() Noralf Trønnes
2019-02-03 15:41 ` [PATCH 4/6] drm/udl: " Noralf Trønnes
2019-02-07 21:07   ` Sean Paul [this message]
2019-02-03 15:41 ` [PATCH 5/6] drm/xen: " Noralf Trønnes
     [not found]   ` <20190203154200.61479-6-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-02-04 10:42     ` Oleksandr Andrushchenko
2019-02-04 13:13       ` Noralf Trønnes
2019-02-03 15:42 ` [PATCH 6/6] drm/drv: Remove drm_dev_unplug() Noralf Trønnes
     [not found]   ` <20190203154200.61479-7-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-02-04 10:44     ` Oleksandr Andrushchenko
2019-02-07 21:08     ` Sean Paul
2019-02-03 16:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-02-03 17:59 ` ✓ Fi.CI.IGT: " Patchwork
2019-02-04 10:05 ` [PATCH 0/6] " Daniel Vetter
2019-02-04 12:45 ` Koenig, Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190207210752.GF114153@art_vandelay \
    --to=sean@poorly.run \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=noralf@tronnes.org \
    --cc=oleksandr_andrushchenko@epam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox