From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: [PATCH 4/6] drm/i915/psr: Remove PSR2 FIXME
Date: Thu, 7 Feb 2019 14:24:26 -0800 [thread overview]
Message-ID: <20190207222428.16785-4-jose.souza@intel.com> (raw)
In-Reply-To: <20190207222428.16785-1-jose.souza@intel.com>
Now we are checking sink capabilities when probing PSR DPCD register
and then dynamically checking in if new state is compatible with PSR
in, so this FIXME can be dropped.
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_psr.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 75c1a5deebf5..8bed73914876 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -532,11 +532,6 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
int crtc_vdisplay = crtc_state->base.adjusted_mode.crtc_vdisplay;
int psr_max_h = 0, psr_max_v = 0;
- /*
- * FIXME psr2_support is messed up. It's both computed
- * dynamically during PSR enable, and extracted from sink
- * caps during eDP detection.
- */
if (!dev_priv->psr.sink_psr2_support)
return false;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-07 22:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 22:24 [PATCH 1/6] drm/i915: Compute has_drrs after compute has_psr José Roberto de Souza
2019-02-07 22:24 ` [PATCH 2/6] drm/i915/drrs: Disable DRRS when needed in fastsets José Roberto de Souza
2019-02-07 22:24 ` [PATCH 3/6] drm/i915/drrs: Refactor intel_dp_set_drrs_state() José Roberto de Souza
2019-02-08 5:34 ` kbuild test robot
2019-02-07 22:24 ` José Roberto de Souza [this message]
2019-02-14 0:28 ` [PATCH 4/6] drm/i915/psr: Remove PSR2 FIXME Dhinakaran Pandiyan
2019-02-07 22:24 ` [PATCH 5/6] drm/i915/psr: Initialize PSR mutex even when sink is not reliable José Roberto de Souza
2019-02-07 22:24 ` [PATCH 6/6] drm/i915/psr: Do not enable PSR in interlaced mode for all GENs José Roberto de Souza
2019-02-07 23:14 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Compute has_drrs after compute has_psr Patchwork
2019-02-08 2:58 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207222428.16785-4-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox