From: Daniel Vetter <daniel@ffwll.ch>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
tomas.winkler@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v14 09/35] drm: helper functions for hdcp2 seq_num to from u32
Date: Fri, 15 Feb 2019 18:56:08 +0100 [thread overview]
Message-ID: <20190215175608.GQ2665@phenom.ffwll.local> (raw)
In-Reply-To: <1550219730-17734-10-git-send-email-ramalingam.c@intel.com>
On Fri, Feb 15, 2019 at 02:05:04PM +0530, Ramalingam C wrote:
> Library functions for endianness are aligned for 16/32/64 bits.
> But hdcp sequence numbers are 24bits(big endian).
> So for their conversion to and from u32 helper functions are developed.
>
> v2:
> Comment is updated. [Daniel]
> Reviewed-by Uma.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Merged into topic/mei-hdcp. With these four patches we have everything
from this series to create the mei-hdcp branch. At least worked out fine
when I tested it here locally.
Also means you need to rebase&resend, but seems like CI ignored you anyway
:-(
Cheers, Daniel
> ---
> include/drm/drm_hdcp.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index d6dfef8cff6a..7260b31af276 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -252,4 +252,22 @@ struct hdcp2_dp_errata_stream_type {
> #define HDCP_2_2_HDMI_RXSTATUS_READY(x) ((x) & BIT(2))
> #define HDCP_2_2_HDMI_RXSTATUS_REAUTH_REQ(x) ((x) & BIT(3))
>
> +/*
> + * Helper functions to convert 24bit big endian hdcp sequence number to
> + * host format and back
> + */
> +static inline
> +u32 drm_hdcp2_seq_num_to_u32(u8 seq_num[HDCP_2_2_SEQ_NUM_LEN])
> +{
> + return (u32)(seq_num[2] | seq_num[1] << 8 | seq_num[0] << 16);
> +}
> +
> +static inline
> +void drm_hdcp2_u32_to_seq_num(u8 seq_num[HDCP_2_2_SEQ_NUM_LEN], u32 val)
> +{
> + seq_num[0] = val >> 16;
> + seq_num[1] = val >> 8;
> + seq_num[2] = val;
> +}
> +
> #endif
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-15 17:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 8:34 [PATCH v14 00/35] drm/i915: Implement HDCP2.2 Ramalingam C
2019-02-15 8:34 ` [PATCH v14 01/35] drm/i915: Gathering the HDCP1.4 routines together Ramalingam C
2019-02-15 8:34 ` [PATCH v14 02/35] drm: enum port definition is moved into i915_drm.h Ramalingam C
2019-02-15 17:47 ` Daniel Vetter
2019-02-15 8:34 ` [PATCH v14 03/35] drm: header for i915 - MEI_HDCP interface Ramalingam C
2019-02-15 17:47 ` Daniel Vetter
2019-02-15 8:34 ` [PATCH v14 04/35] drm/i915: Initialize HDCP2.2 Ramalingam C
2019-02-15 8:35 ` [PATCH v14 05/35] drm/i915: MEI interface definition Ramalingam C via dri-devel
2019-02-15 17:53 ` Daniel Vetter
2019-02-15 8:35 ` [PATCH v14 06/35] drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking Ramalingam C
2019-02-15 8:35 ` [PATCH v14 07/35] drm/i915: Enable and Disable of HDCP2.2 Ramalingam C
2019-02-15 8:35 ` [PATCH v14 08/35] drm/i915: Implement HDCP2.2 receiver authentication Ramalingam C
2019-02-15 8:35 ` [PATCH v14 09/35] drm: helper functions for hdcp2 seq_num to from u32 Ramalingam C
2019-02-15 17:56 ` Daniel Vetter [this message]
2019-02-15 8:35 ` [PATCH v14 10/35] drm/i915: Implement HDCP2.2 repeater authentication Ramalingam C
2019-02-15 8:35 ` [PATCH v14 11/35] drm: HDCP2.2 link check period Ramalingam C
2019-02-15 8:35 ` [PATCH v14 12/35] drm/i915: Implement HDCP2.2 link integrity check Ramalingam C
2019-02-15 8:35 ` [PATCH v14 13/35] drm/i915: Handle HDCP2.2 downstream topology change Ramalingam C
2019-02-15 8:35 ` [PATCH v14 14/35] drm: removing the DP Errata msg and its msg id Ramalingam C
2019-02-15 8:35 ` [PATCH v14 15/35] drm/i915: Implement the HDCP2.2 support for DP Ramalingam C via dri-devel
2019-02-15 8:35 ` [PATCH v14 16/35] drm/i915: Implement the HDCP2.2 support for HDMI Ramalingam C
2019-02-15 8:35 ` [PATCH v14 17/35] drm/i915: CP_IRQ handling for DP HDCP2.2 msgs Ramalingam C
2019-02-15 8:35 ` [PATCH v14 18/35] drm/i915: Fix KBL HDCP2.2 encrypt status signalling Ramalingam C via dri-devel
2019-02-15 8:35 ` [PATCH v14 19/35] mei: bus: whitelist hdcp client Ramalingam C
2019-02-15 8:35 ` [PATCH v14 20/35] mei: bus: export to_mei_cl_device for mei client device drivers Ramalingam C
2019-02-15 8:35 ` [PATCH v14 21/35] misc/mei/hdcp: Client driver for HDCP application Ramalingam C
2019-02-15 8:35 ` [PATCH v14 22/35] misc/mei/hdcp: Define ME FW interface for HDCP2.2 Ramalingam C
2019-02-15 8:35 ` [PATCH v14 23/35] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session Ramalingam C
2019-02-15 8:35 ` [PATCH v14 24/35] misc/mei/hdcp: Verify Receiver Cert and prepare km Ramalingam C
2019-02-15 8:35 ` [PATCH v14 25/35] misc/mei/hdcp: Verify H_prime Ramalingam C
2019-02-15 8:35 ` [PATCH v14 26/35] misc/mei/hdcp: Store the HDCP Pairing info Ramalingam C via dri-devel
2019-02-15 8:35 ` [PATCH v14 27/35] misc/mei/hdcp: Initiate Locality check Ramalingam C
2019-02-15 8:35 ` [PATCH v14 28/35] misc/mei/hdcp: Verify L_prime Ramalingam C
2019-02-15 8:35 ` [PATCH v14 29/35] misc/mei/hdcp: Prepare Session Key Ramalingam C
2019-02-15 8:35 ` [PATCH v14 30/35] misc/mei/hdcp: Repeater topology verification and ack Ramalingam C
2019-02-15 8:35 ` [PATCH v14 31/35] misc/mei/hdcp: Verify M_prime Ramalingam C
2019-02-15 8:35 ` [PATCH v14 32/35] misc/mei/hdcp: Enabling the HDCP authentication Ramalingam C via dri-devel
2019-02-15 8:35 ` [PATCH v14 33/35] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session Ramalingam C
2019-02-15 8:35 ` [PATCH v14 34/35] misc/mei/hdcp: Component framework for I915 Interface Ramalingam C
2019-02-15 8:35 ` [PATCH v14 35/35] FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915 Ramalingam C
2019-02-16 20:46 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 Patchwork
2019-02-16 20:56 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-02-16 21:07 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215175608.GQ2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox