public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm: move i915_kick_out_vgacon to drm_fb_helper
Date: Thu, 21 Feb 2019 15:59:34 -0000	[thread overview]
Message-ID: <20190221155934.1706.36568@emeril.freedesktop.org> (raw)
In-Reply-To: <20190221154733.5516-1-kraxel@redhat.com>

== Series Details ==

Series: drm: move i915_kick_out_vgacon to drm_fb_helper
URL   : https://patchwork.freedesktop.org/series/57029/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
38991d86186b drm: move i915_kick_out_vgacon to drm_fb_helper
-:31: ERROR:CODE_INDENT: code indent should use tabs where possible
#31: FILE: drivers/gpu/drm/drm_fb_helper.c:3363:
+        return 0;$

-:31: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#31: FILE: drivers/gpu/drm/drm_fb_helper.c:3363:
+        return 0;$

-:36: ERROR:CODE_INDENT: code indent should use tabs where possible
#36: FILE: drivers/gpu/drm/drm_fb_helper.c:3368:
+        return -ENODEV;$

-:36: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#36: FILE: drivers/gpu/drm/drm_fb_helper.c:3368:
+        return -ENODEV;$

-:41: ERROR:CODE_INDENT: code indent should use tabs where possible
#41: FILE: drivers/gpu/drm/drm_fb_helper.c:3373:
+        int ret = 0;$

-:41: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#41: FILE: drivers/gpu/drm/drm_fb_helper.c:3373:
+        int ret = 0;$

-:43: ERROR:CODE_INDENT: code indent should use tabs where possible
#43: FILE: drivers/gpu/drm/drm_fb_helper.c:3375:
+        DRM_INFO("Replacing VGA console driver\n");$

-:43: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#43: FILE: drivers/gpu/drm/drm_fb_helper.c:3375:
+        DRM_INFO("Replacing VGA console driver\n");$

-:45: ERROR:CODE_INDENT: code indent should use tabs where possible
#45: FILE: drivers/gpu/drm/drm_fb_helper.c:3377:
+        console_lock();$

-:45: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: drivers/gpu/drm/drm_fb_helper.c:3377:
+        console_lock();$

-:46: ERROR:CODE_INDENT: code indent should use tabs where possible
#46: FILE: drivers/gpu/drm/drm_fb_helper.c:3378:
+        if (con_is_bound(&vga_con))$

-:46: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#46: FILE: drivers/gpu/drm/drm_fb_helper.c:3378:
+        if (con_is_bound(&vga_con))$

-:47: ERROR:CODE_INDENT: code indent should use tabs where possible
#47: FILE: drivers/gpu/drm/drm_fb_helper.c:3379:
+                ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);$

-:47: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#47: FILE: drivers/gpu/drm/drm_fb_helper.c:3379:
+                ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);$

-:48: ERROR:CODE_INDENT: code indent should use tabs where possible
#48: FILE: drivers/gpu/drm/drm_fb_helper.c:3380:
+        if (ret == 0) {$

-:48: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#48: FILE: drivers/gpu/drm/drm_fb_helper.c:3380:
+        if (ret == 0) {$

-:49: ERROR:CODE_INDENT: code indent should use tabs where possible
#49: FILE: drivers/gpu/drm/drm_fb_helper.c:3381:
+                ret = do_unregister_con_driver(&vga_con);$

-:49: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#49: FILE: drivers/gpu/drm/drm_fb_helper.c:3381:
+                ret = do_unregister_con_driver(&vga_con);$

-:51: ERROR:CODE_INDENT: code indent should use tabs where possible
#51: FILE: drivers/gpu/drm/drm_fb_helper.c:3383:
+                /* Ignore "already unregistered". */$

-:52: ERROR:CODE_INDENT: code indent should use tabs where possible
#52: FILE: drivers/gpu/drm/drm_fb_helper.c:3384:
+                if (ret == -ENODEV)$

-:52: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#52: FILE: drivers/gpu/drm/drm_fb_helper.c:3384:
+                if (ret == -ENODEV)$

-:53: ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: drivers/gpu/drm/drm_fb_helper.c:3385:
+                        ret = 0;$

-:53: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: drivers/gpu/drm/drm_fb_helper.c:3385:
+                        ret = 0;$

-:54: ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: drivers/gpu/drm/drm_fb_helper.c:3386:
+        }$

-:54: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#54: FILE: drivers/gpu/drm/drm_fb_helper.c:3386:
+        }$

-:55: ERROR:CODE_INDENT: code indent should use tabs where possible
#55: FILE: drivers/gpu/drm/drm_fb_helper.c:3387:
+        console_unlock();$

-:55: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#55: FILE: drivers/gpu/drm/drm_fb_helper.c:3387:
+        console_unlock();$

-:57: ERROR:CODE_INDENT: code indent should use tabs where possible
#57: FILE: drivers/gpu/drm/drm_fb_helper.c:3389:
+        return ret;$

-:57: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: drivers/gpu/drm/drm_fb_helper.c:3389:
+        return ret;$

total: 15 errors, 14 warnings, 0 checks, 143 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-02-21 15:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 15:47 [PATCH v3] drm: move i915_kick_out_vgacon to drm_fb_helper Gerd Hoffmann
2019-02-21 15:59 ` Patchwork [this message]
2019-02-21 16:18 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-02-22  3:52 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190221155934.1706.36568@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox