From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove unused HAS_PCH_CNP_LP
Date: Fri, 22 Feb 2019 13:37:37 -0800 [thread overview]
Message-ID: <20190222213737.GH2855@intel.com> (raw)
In-Reply-To: <20190221230800.najfgdvqjbtqqfhw@ldmartin-desk.jf.intel.com>
On Thu, Feb 21, 2019 at 03:08:00PM -0800, Lucas De Marchi wrote:
> On Thu, Feb 21, 2019 at 01:17:16PM -0800, Rodrigo Vivi wrote:
> > Other than LPT, no other PCH needed to differentiate between
> > LP and HP. So let's remove this before we spread this mistake
> > to future platforms.
> >
> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
thanks, pushed to dinq
>
> Lucas De Marchi
>
> > ---
> > drivers/gpu/drm/i915/i915_drv.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index bb0e75e43987..cc09caf3870e 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -2574,8 +2574,6 @@ static inline unsigned int i915_sg_segment_size(void)
> > #define INTEL_PCH_ID(dev_priv) ((dev_priv)->pch_id)
> > #define HAS_PCH_ICP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_ICP)
> > #define HAS_PCH_CNP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_CNP)
> > -#define HAS_PCH_CNP_LP(dev_priv) \
> > - (INTEL_PCH_ID(dev_priv) == INTEL_PCH_CNP_LP_DEVICE_ID_TYPE)
> > #define HAS_PCH_KBP(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_KBP)
> > #define HAS_PCH_SPT(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_SPT)
> > #define HAS_PCH_LPT(dev_priv) (INTEL_PCH_TYPE(dev_priv) == PCH_LPT)
> > --
> > 2.20.1
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-22 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 21:17 [PATCH] drm/i915: Remove unused HAS_PCH_CNP_LP Rodrigo Vivi
2019-02-21 23:08 ` Lucas De Marchi
2019-02-22 21:37 ` Rodrigo Vivi [this message]
2019-02-21 23:29 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-02-21 23:51 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-22 12:59 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222213737.GH2855@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox