From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix the state checker for ICL Y planes
Date: Mon, 4 Mar 2019 16:55:09 +0200 [thread overview]
Message-ID: <20190304145509.GV20097@intel.com> (raw)
In-Reply-To: <20190304144528.GB29434@ideak-desk.fi.intel.com>
On Mon, Mar 04, 2019 at 04:45:28PM +0200, Imre Deak wrote:
> On Mon, Mar 04, 2019 at 03:12:17PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The plane used to scan out NV12 luma on ICL is logically
> > off but actually on. Fix the state checker to account for this.
> >
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109457
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 7c5e84ef5171..b49e789b747e 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -12589,7 +12589,8 @@ intel_verify_planes(struct intel_atomic_state *state)
> >
> > for_each_new_intel_plane_in_state(state, plane,
> > plane_state, i)
> > - assert_plane(plane, plane_state->base.visible);
> > + assert_plane(plane, plane_state->slave ||
> > + plane_state->base.visible);
>
> Looks like we don't have proper readout for such linked planes either,
> but that's a separate issue.
We have no real plane state readout for any plane. The only slight
exception is the initial_plane_config() stuff.
> The change looks ok:
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> > }
> >
> > static void
> > --
> > 2.19.2
> >
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-04 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 13:12 [PATCH] drm/i915: Fix the state checker for ICL Y planes Ville Syrjala
2019-03-04 14:01 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-04 14:45 ` [PATCH] " Imre Deak
2019-03-04 14:52 ` Maarten Lankhorst
2019-03-04 14:55 ` Ville Syrjälä [this message]
2019-03-04 17:50 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304145509.GV20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox