From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Forcing a modeset when resetting HDMI link
Date: Mon, 4 Mar 2019 18:34:39 +0200 [thread overview]
Message-ID: <20190304163439.GZ20097@intel.com> (raw)
In-Reply-To: <20190302003349.19189-3-jose.souza@intel.com>
On Fri, Mar 01, 2019 at 04:33:49PM -0800, José Roberto de Souza wrote:
> With fastboot enabled in gen9+ it broke the HDMI reset as just
> setting mode_changed to true causes a fastset and here we want a full
> modeset that will disable and then enable the encoder of this HDMI
> link actually, so setting connectors_changed instead that will cause
> modeset as desired.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
The two other questionable places seem to be:
* intel_digital_connector_atomic_check()
Looks like this is currently broken as we don't do infoframe/audio
updates from the .update_pipe() hook yet. Also we have no
.update_pipe() for pre-ddi platforms.
* intel_modeset_all_pipes()
Should work because we set the flag after the modeset->fastset
downgrade has occurred. Might make sense to change this one as
well though, just to avoid copy paste errors in the future.
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index c22ddde2dfc1..d329f0c206ec 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3973,7 +3973,7 @@ static int modeset_pipe(struct drm_crtc *crtc,
> goto out;
> }
>
> - crtc_state->mode_changed = true;
> + crtc_state->connectors_changed = true;
>
> ret = drm_atomic_commit(state);
> out:
> --
> 2.21.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-04 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 0:33 [PATCH 1/3] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
2019-03-02 0:33 ` [PATCH 2/3] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
2019-03-02 0:33 ` [PATCH 3/3] drm/i915: Forcing a modeset when resetting HDMI link José Roberto de Souza
2019-03-04 16:34 ` Ville Syrjälä [this message]
2019-03-04 23:07 ` Souza, Jose
2019-03-02 0:49 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Fix atomic state leak " Patchwork
2019-03-02 1:18 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-02 9:31 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-07 18:12 ` [PATCH 1/3] " Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304163439.GZ20097@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox