From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH v4 9/9] drm/i915: Enable PSR2 by default
Date: Mon, 4 Mar 2019 10:43:31 -0800 [thread overview]
Message-ID: <20190304184331.GG10303@intel.com> (raw)
In-Reply-To: <20190302013456.24138-9-jose.souza@intel.com>
On Fri, Mar 01, 2019 at 05:34:56PM -0800, José Roberto de Souza wrote:
> The support for PSR2 was polished, IGT tests for PSR2 was added and
> it was tested performing regular user workloads like browsing,
> editing documents and compiling Linux, so it is time to enable it by
> default and enjoy even more power-savings.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
\o/ !
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_psr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index b237d96db277..116c8b50ee78 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -80,9 +80,6 @@ static bool intel_psr2_enabled(struct drm_i915_private *dev_priv,
> case I915_PSR_DEBUG_DISABLE:
> case I915_PSR_DEBUG_FORCE_PSR1:
> return false;
> - case I915_PSR_DEBUG_DEFAULT:
> - if (i915_modparams.enable_psr <= 0)
> - return false;
> default:
> return crtc_state->has_psr2;
> }
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-04 18:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 1:34 [PATCH v4 1/9] drm/i915/psr: Remove PSR2 FIXME José Roberto de Souza
2019-03-02 1:34 ` [PATCH v4 2/9] drm/i915/psr: Only lookup for enabled CRTCs when forcing a fastset José Roberto de Souza
2019-03-02 1:34 ` [PATCH v4 3/9] drm/i915: Compute and commit color features in fastsets José Roberto de Souza
2019-03-02 1:34 ` [PATCH v4 4/9] drm/i915/psr: Drop test for EDP in CRTC when forcing commit José Roberto de Souza
2019-03-04 18:28 ` Rodrigo Vivi
2019-03-02 1:34 ` [PATCH v4 5/9] drm/i915/crc: Make IPS workaround generic José Roberto de Souza
2019-03-04 18:34 ` Rodrigo Vivi
2019-03-02 1:34 ` [PATCH v4 6/9] drm/i915: Disable PSR2 while getting pipe CRC José Roberto de Souza
2019-03-04 18:39 ` Rodrigo Vivi
2019-03-02 1:34 ` [PATCH v4 7/9] drm/i915: Drop redundant checks to update PSR state José Roberto de Souza
2019-03-04 18:42 ` Rodrigo Vivi
2019-03-04 18:54 ` Dhinakaran Pandiyan
2019-03-04 20:45 ` Souza, Jose
2019-03-02 1:34 ` [PATCH v4 8/9] drm/i915/psr: Set idle frames to maximum while getting pipe CRC José Roberto de Souza
2019-03-04 18:31 ` Dhinakaran Pandiyan
2019-03-04 18:40 ` Souza, Jose
2019-03-04 19:00 ` Dhinakaran Pandiyan
2019-03-04 20:56 ` Souza, Jose
2019-03-02 1:34 ` [PATCH v4 9/9] drm/i915: Enable PSR2 by default José Roberto de Souza
2019-03-04 18:43 ` Rodrigo Vivi [this message]
2019-03-02 2:34 ` ✗ Fi.CI.SPARSE: warning for series starting with [v4,1/9] drm/i915/psr: Remove PSR2 FIXME Patchwork
2019-03-02 2:51 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-02 13:38 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304184331.GG10303@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox