From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/bios: parse ddi ports also on VLV
Date: Wed, 6 Mar 2019 19:53:05 +0200 [thread overview]
Message-ID: <20190306175305.GI3888@intel.com> (raw)
In-Reply-To: <00a286df2820145d454378bc20a91d860c1ae9e8.1551886309.git.jani.nikula@intel.com>
On Wed, Mar 06, 2019 at 05:34:16PM +0200, Jani Nikula wrote:
> The main benefit is improved debug logging of the ports also on VLV.
The fact that this causes VLV to start using the AUX/DDC pins from VBT
needs to be called out in the commit msg.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_bios.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 9beff569b010..030a5e9c67b3 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1514,7 +1514,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version)
> const struct child_device_config *child;
> int i;
>
> - if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
> + if (!HAS_DDI(dev_priv) &&
> + !IS_CHERRYVIEW(dev_priv) && !IS_VALLEYVIEW(dev_priv))
> return;
>
> if (bdb_version < 155)
> --
> 2.20.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-06 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 15:34 [PATCH 0/3] drm/i915/bios: ddi port parsing changes Jani Nikula
2019-03-06 15:34 ` [PATCH 1/3] drm/i915/bios: iterate over child devices to initialize ddi_port_info Jani Nikula
2019-03-06 18:55 ` Ville Syrjälä
2019-03-06 15:34 ` [PATCH 2/3] drm/i915/bios: parse dsi devices in parse_ddi_ports() Jani Nikula
2019-03-06 17:51 ` Ville Syrjälä
2019-03-07 10:18 ` Jani Nikula
2019-03-07 18:31 ` Ville Syrjälä
2019-03-06 15:34 ` [PATCH 3/3] drm/i915/bios: parse ddi ports also on VLV Jani Nikula
2019-03-06 17:53 ` Ville Syrjälä [this message]
2019-03-06 16:00 ` ✗ Fi.CI.SPARSE: warning for drm/i915/bios: ddi port parsing changes Patchwork
2019-03-06 17:05 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306175305.GI3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox