From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 19/19] i915/gem_exec_balancer: Exercise bonded pairs
Date: Mon, 11 Mar 2019 12:30:23 +0200 [thread overview]
Message-ID: <20190311103023.GB2541@intel.intel> (raw)
In-Reply-To: <20190308181129.15562-19-chris@chris-wilson.co.uk>
Hi again,
I was thinking...
> +static void bonded(int i915, unsigned int flags)
> +#define CORK 0x1
> +{
> + struct class_instance *master_engines;
... shall we just make 'struct class_instance' generic in the
uapi? I do not expect every test that uses class and instance to
define its own structure.
Besides we can avoid a good load of 'offsetof' and make the whole
thing more readable.
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-11 10:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 18:11 [PATCH i-g-t 01/19] i915/gem_ppgtt: Estimate resource usage and bail if it means swapping! Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 02/19] lib/i915: Pretty print HW semaphores Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 03/19] lib: Add GPU power measurement Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 04/19] i915/gem_exec_schedule: Measure semaphore power consumption Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 05/19] i915/gem_exec_whisper: Measure total power consumed Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 06/19] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 07/19] i915/gem_exec_nop: poll-sequential requires ordering between rings Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 08/19] i915/gem_sync: Make switch-default asymmetric Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 09/19] i915/gem_ctx_param: Remove kneecapping Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 10/19] i915/gem_exec_big: Add a single shot test Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 11/19] kms_fence_pin_leak: Ask for the GPU before use Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 12/19] drm-uapi: Import i915_drm.h upto 364df3d04d51 Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 13/19] i915: Exercise creating context with shared GTT Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 14/19] igt/gem_ctx_switch: Exercise queues Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 15/19] igt/gem_exec_whisper: Fork all-engine tests one-per-engine Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 16/19] i915/gem_exec_whisper: debugfs/next_seqno is defunct Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 17/19] i915: Add gem_ctx_engines Chris Wilson
2019-03-11 10:00 ` Andi Shyti
2019-03-08 18:11 ` [PATCH i-g-t 18/19] i915: Add gem_exec_balancer Chris Wilson
2019-03-12 10:23 ` Tvrtko Ursulin
2019-03-12 10:27 ` Chris Wilson
2019-03-08 18:11 ` [PATCH i-g-t 19/19] i915/gem_exec_balancer: Exercise bonded pairs Chris Wilson
2019-03-11 10:18 ` Andi Shyti
2019-03-11 10:30 ` Andi Shyti [this message]
2019-03-11 10:39 ` Chris Wilson
2019-03-09 2:07 ` ✗ Fi.CI.BAT: failure for series starting with [01/19] i915/gem_ppgtt: Estimate resource usage and bail if it means swapping! Patchwork
2019-03-11 10:04 ` [PATCH i-g-t 01/19] " Mika Kuoppala
2019-03-11 10:09 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311103023.GB2541@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox