From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vanshidhar Konda <vanshidhar.r.konda@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: Reduce log level for DP command signal timeout
Date: Thu, 14 Mar 2019 22:47:56 +0200 [thread overview]
Message-ID: <20190314204756.GX3888@intel.com> (raw)
In-Reply-To: <20190314202600.GA55826@vrkonda-desk.ra.intel.com>
On Thu, Mar 14, 2019 at 01:26:00PM -0700, Vanshidhar Konda wrote:
> On Thu, Mar 14, 2019 at 08:39:11PM +0200, Ville Syrjälä wrote:
> >On Thu, Mar 14, 2019 at 10:58:49AM -0700, Vanshidhar Konda wrote:
> >> The log level for timeout after waiting for a signal on the DP aux
> >> channel control register is set to DRM_ERROR. But this is timeout not a
> >> fatal error as the driver is expected to retry the command. Failure
> >> after all retries is already captured as an error. Hence, reducing the
> >> log for a timeout to warning instead of error.
> >> ---
> >> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> >> index 47857f96c3b1..f51e8b2ccb17 100644
> >> --- a/drivers/gpu/drm/i915/intel_dp.c
> >> +++ b/drivers/gpu/drm/i915/intel_dp.c
> >> @@ -1069,7 +1069,7 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> >> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> >>
> >> if (!done)
> >> - DRM_ERROR("dp aux hw did not signal timeout!\n");
> >> + DRM_WARN("dp aux hw did not signal timeout!\n");
> >
> >IIRC this indicates the hw is broken.
> >
> Does this indicate an issue with Intel GFX/display device, or the
> display/monitor connected to the DP port?
>
> FYI, this is for FDO #109982
> (https://bugzilla.freedesktop.org/show_bug.cgi?id=109982).
There's nothing connected I believe. But in either case I believe
the aux hw should terminate with a proper timeout. I'm tempted to
blame the typec/tbt stuff here too.
>
> >From the logs, it seems like this timeout only occurs once. The next try
> succeeds without issues.
>
> >> #undef C
> >>
> >> return status;
> >> --
> >> 2.20.1
> >>
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> >--
> >Ville Syrjälä
> >Intel
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-14 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 17:58 [PATCH] drm/i915/display: Reduce log level for DP command signal timeout Vanshidhar Konda
2019-03-14 18:31 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-03-14 18:37 ` [PATCH] " Vanshidhar Konda
2019-03-14 18:39 ` Ville Syrjälä
2019-03-14 20:26 ` Vanshidhar Konda
2019-03-14 20:47 ` Ville Syrjälä [this message]
2019-03-14 21:00 ` Vanshidhar Konda
2019-03-14 21:09 ` Ville Syrjälä
2019-03-15 1:37 ` Vanshidhar Konda
2019-03-15 13:35 ` Ville Syrjälä
2019-03-15 15:59 ` Vanshidhar Konda
2019-03-14 19:08 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-15 4:01 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314204756.GX3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vanshidhar.r.konda@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox