public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v6 0/2] drm/i915: Ensure minimum CDCLK requirement for audio
Date: Mon, 18 Mar 2019 16:34:33 +0200	[thread overview]
Message-ID: <20190318143435.1686-1-imre.deak@intel.com> (raw)

This replaces [1] and [2]. The main changes since then:

- A device link between i915 and HDA (added meanwhile as a separate
  change).
- Split the CDCLK change to happen before or after any updates
  to the pipe depending on whether we're increasing or decreasing
  CDCLK.
- Wait for vblank after an optimized CDCLK update.

Abhay confirmed that the patchset fixes the audio issues his team
saw due to too low CDCLK.

[1] https://patchwork.freedesktop.org/patch/230817/?series=42459&rev=7
[2] https://patchwork.freedesktop.org/series/48763/

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Abhay Kumar <abhay.kumar@intel.com>
Tested-by: Abhay Kumar <abhay.kumar@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>

Ville Syrjälä (2):
  drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled
  drm/i915: Skip modeset for cdclk changes if possible

 drivers/gpu/drm/i915/i915_drv.h      |   6 +-
 drivers/gpu/drm/i915/i915_reg.h      |   3 +-
 drivers/gpu/drm/i915/intel_audio.c   |  68 ++++++++++++-
 drivers/gpu/drm/i915/intel_cdclk.c   | 185 +++++++++++++++++++++++++----------
 drivers/gpu/drm/i915/intel_display.c |  48 ++++++++-
 drivers/gpu/drm/i915/intel_drv.h     |  18 +++-
 6 files changed, 268 insertions(+), 60 deletions(-)

-- 
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-03-18 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 14:34 Imre Deak [this message]
2019-03-18 14:34 ` [PATCH v6 1/2] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled Imre Deak
2019-03-18 14:34 ` [PATCH v6 2/2] drm/i915: Skip modeset for cdclk changes if possible Imre Deak
2019-03-18 18:37   ` Ville Syrjälä
2019-03-18 19:16     ` Imre Deak
2019-03-18 18:01 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Ensure minimum CDCLK requirement for audio Patchwork
2019-03-18 18:03 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-18 18:20 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-19  2:56 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318143435.1686-1-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox