From: Manasi Navare <manasi.d.navare@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/icl: Fix the TRANS_DDI_FUNC_CTL2 bitfield macro
Date: Wed, 20 Mar 2019 12:15:11 -0700 [thread overview]
Message-ID: <20190320191510.GA1776@intel.com> (raw)
In-Reply-To: <877ectgb0i.fsf@intel.com>
Pushed to dinq, thanks for the review!
Regards
Manasi
On Wed, Mar 20, 2019 at 11:17:49AM +0200, Jani Nikula wrote:
> On Tue, 19 Mar 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> > This patch fixes the PORT_SYNC_MODE_MASTER_SELECT macro
> > to correctly do the left shifting to set the port sync
> > master select correctly.
> > I have tested this fix on ICL.
> >
> > Fixes: 49edbd49786e ("drm/i915/icl: Define TRANS_DDI_FUNC_CTL DSI registers")
> > Cc: Madhav Chauhan <madhav.chauhan@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>
> Auch.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 85e8d1a1f70b..7a9d867eb49b 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -9352,7 +9352,7 @@ enum skl_power_gate {
> > #define TRANS_DDI_FUNC_CTL2(tran) _MMIO_TRANS2(tran, \
> > _TRANS_DDI_FUNC_CTL2_A)
> > #define PORT_SYNC_MODE_ENABLE (1 << 4)
> > -#define PORT_SYNC_MODE_MASTER_SELECT(x) ((x) < 0)
> > +#define PORT_SYNC_MODE_MASTER_SELECT(x) ((x) << 0)
> > #define PORT_SYNC_MODE_MASTER_SELECT_MASK (0x7 << 0)
> > #define PORT_SYNC_MODE_MASTER_SELECT_SHIFT 0
>
> --
> Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-20 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 22:18 [PATCH] drm/i915/icl: Fix the TRANS_DDI_FUNC_CTL2 bitfield macro Manasi Navare
2019-03-19 23:09 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-20 9:17 ` [PATCH] " Jani Nikula
2019-03-20 19:15 ` Manasi Navare [this message]
2019-03-20 9:18 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320191510.GA1776@intel.com \
--to=manasi.d.navare@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox