public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/2] drm/i915: Add missing scanline case for 8 cpp watermarks.
Date: Thu, 21 Mar 2019 10:15:45 +0100	[thread overview]
Message-ID: <20190321091546.28130-1-maarten.lankhorst@linux.intel.com> (raw)

Now that we can rotate 64 bpp formats, we need to add the rotation case.
This wasn't caught by CI or me, because the rotated formats were skipping
because the rotated watermarks exceeded the allocation limits.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index fcd3baff8b65..5977dca2c55d 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4689,6 +4689,9 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state,
 		case 4:
 			wp->y_min_scanlines = 4;
 			break;
+		case 8:
+			wp->y_min_scanlines = 2;
+			break;
 		default:
 			MISSING_CASE(wp->cpp);
 			return -EINVAL;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-03-21  9:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  9:15 Maarten Lankhorst [this message]
2019-03-21  9:15 ` [PATCH 2/2] drm/i915: Reject Yf tiling for 8cpp formats Maarten Lankhorst
2019-03-21 10:27   ` Ville Syrjälä
2019-03-21 11:59     ` Maarten Lankhorst
2019-03-21 10:29 ` [PATCH 1/2] drm/i915: Add missing scanline case for 8 cpp watermarks Ville Syrjälä
2019-03-21 12:48   ` Maarten Lankhorst
2019-03-21 12:10 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-03-21 23:19 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321091546.28130-1-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox