From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: stop storing the media fuse
Date: Fri, 22 Mar 2019 02:09:59 -0000 [thread overview]
Message-ID: <20190322020959.14934.40258@emeril.freedesktop.org> (raw)
In-Reply-To: <20190322002431.9585-1-daniele.ceraolospurio@intel.com>
== Series Details ==
Series: drm/i915: stop storing the media fuse
URL : https://patchwork.freedesktop.org/series/58387/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
de5dfcc93c76 drm/i915: stop storing the media fuse
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'first' - possible side-effects?
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:2443:
+#define ENGINE_INSTANCES_MASK(dev_priv, first, count) \
+ ((INTEL_INFO(dev_priv)->engine_mask & \
+ GENMASK(first + count - 1, first)) >> first)
-:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'first' may be better as '(first)' to avoid precedence issues
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:2443:
+#define ENGINE_INSTANCES_MASK(dev_priv, first, count) \
+ ((INTEL_INFO(dev_priv)->engine_mask & \
+ GENMASK(first + count - 1, first)) >> first)
-:23: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'count' may be better as '(count)' to avoid precedence issues
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:2443:
+#define ENGINE_INSTANCES_MASK(dev_priv, first, count) \
+ ((INTEL_INFO(dev_priv)->engine_mask & \
+ GENMASK(first + count - 1, first)) >> first)
-:26: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#26: FILE: drivers/gpu/drm/i915/i915_drv.h:2446:
+#define VDBOX_MASK(dev_priv) ENGINE_INSTANCES_MASK(dev_priv, VCS0, I915_MAX_VCS);
-:27: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#27: FILE: drivers/gpu/drm/i915/i915_drv.h:2447:
+#define VEBOX_MASK(dev_priv) ENGINE_INSTANCES_MASK(dev_priv, VECS0, I915_MAX_VECS);
total: 0 errors, 2 warnings, 3 checks, 64 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-22 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 0:24 [PATCH] drm/i915: stop storing the media fuse Daniele Ceraolo Spurio
2019-03-22 2:09 ` Patchwork [this message]
2019-03-22 2:11 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-03-22 2:29 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-22 8:29 ` [PATCH] " Chris Wilson
2019-03-25 18:22 ` Michal Wajdeczko
2019-03-22 9:23 ` Tvrtko Ursulin
2019-03-22 9:27 ` Tvrtko Ursulin
2019-03-22 19:35 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322020959.14934.40258@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox