From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Hang Yuan <hang.yuan@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gvt: Fix kerneldoc typo for intel_vgpu_emulate_hotplug
Date: Fri, 22 Mar 2019 16:18:08 +0800 [thread overview]
Message-ID: <20190322081807.GV10798@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <155324271368.26447.10934641971482383309@skylake-alporthouse-com>
[-- Attachment #1.1: Type: text/plain, Size: 1809 bytes --]
On 2019.03.22 08:18:33 +0000, Chris Wilson wrote:
> Quoting Zhenyu Wang (2019-02-18 08:59:07)
> > On 2019.02.05 20:30:33 +0000, Chris Wilson wrote:
> > > drivers/gpu/drm/i915/gvt/display.c:457: warning: Function parameter or member 'connected' not described in 'intel_vgpu_emulate_hotplug'
> > > drivers/gpu/drm/i915/gvt/display.c:457: warning: Excess function parameter 'conncted' description in 'intel_vgpu_emulate_hotplug'
> > >
> > > Fixes: 1ca20f33df42 ("drm/i915/gvt: add hotplug emulation")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Hang Yuan <hang.yuan@linux.intel.com>
> > > Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> > > Cc: Zhi Wang <zhi.a.wang@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/gvt/display.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c
> > > index 035479e273be..e3f9caa7839f 100644
> > > --- a/drivers/gpu/drm/i915/gvt/display.c
> > > +++ b/drivers/gpu/drm/i915/gvt/display.c
> > > @@ -448,7 +448,7 @@ void intel_gvt_emulate_vblank(struct intel_gvt *gvt)
> > > /**
> > > * intel_vgpu_emulate_hotplug - trigger hotplug event for vGPU
> > > * @vgpu: a vGPU
> > > - * @conncted: link state
> > > + * @connected: link state
> > > *
> > > * This function is used to trigger hotplug interrupt for vGPU
> > > *
> > > --
> >
> > Thanks! Applied this, sorry to miss the check..
>
> Still present after the recent gvt merges.
oops, I was pushing this to gvt-next-fixes, but didn't actually
generate the -next-fixes for other dependence. I'll include this
for next pull. Sorry about that.
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-03-22 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 20:30 [PATCH] drm/i915/gvt: Fix kerneldoc typo for intel_vgpu_emulate_hotplug Chris Wilson
2019-02-05 21:22 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-02-06 3:23 ` ✓ Fi.CI.IGT: " Patchwork
2019-02-18 8:59 ` [PATCH] " Zhenyu Wang
2019-03-22 8:18 ` Chris Wilson
2019-03-22 8:18 ` Zhenyu Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322081807.GV10798@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=hang.yuan@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox