Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Robert M. Fosha" <robert.m.fosha@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2] drm/i915/guc: Retry GuC load for all load failures
Date: Fri, 29 Mar 2019 16:17:46 -0700	[thread overview]
Message-ID: <20190329231746.9129-1-robert.m.fosha@intel.com> (raw)
In-Reply-To: <20190329203609.8555-1-robert.m.fosha@intel.com>

Currently we only retry to load GuC firmware if the load fails due to
timeout. On Gen9 GuC loading may fail for different reasons, not just
hang/timeout. Direction from the GuC team is to retry for all cases of
GuC load failure on Gen9, not just for timeout.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108593
Signed-off-by: Robert M. Fosha <robert.m.fosha@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 2d360d53757f..25b80ffe71ad 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -375,7 +375,7 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
 
 		intel_guc_init_params(guc);
 		ret = intel_guc_fw_upload(guc);
-		if (ret == 0 || ret != -ETIMEDOUT)
+		if (ret == 0)
 			break;
 
 		DRM_DEBUG_DRIVER("GuC fw load failed: %d; will reset and "
-- 
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-03-29 23:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 20:36 [PATCH] drm/i915/guc: Retry GuC load for all load failures Robert M. Fosha
2019-03-29 20:43 ` Chris Wilson
2019-03-29 21:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-29 23:17 ` Robert M. Fosha [this message]
2019-03-30  8:01   ` [PATCH v2] " Chris Wilson
2019-03-30  8:07     ` Chris Wilson
2019-03-30  0:54 ` ✓ Fi.CI.BAT: success for drm/i915/guc: Retry GuC load for all load failures (rev2) Patchwork
2019-03-30  1:57 ` ✓ Fi.CI.IGT: success for drm/i915/guc: Retry GuC load for all load failures Patchwork
2019-03-30  3:59 ` ✓ Fi.CI.IGT: success for drm/i915/guc: Retry GuC load for all load failures (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329231746.9129-1-robert.m.fosha@intel.com \
    --to=robert.m.fosha@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox