From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/i915/icl: Simplify release of encoder power refs
Date: Fri, 5 Apr 2019 18:36:57 +0300 [thread overview]
Message-ID: <20190405153657.20921-2-imre.deak@intel.com> (raw)
In-Reply-To: <20190405153657.20921-1-imre.deak@intel.com>
We can unconditionally release the power references during encoder
disabling. The references for each port used by the encoder are
guaranteed to be enabled at this point.
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/icl_dsi.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c
index 90744032da85..c5a3c1f83f8a 100644
--- a/drivers/gpu/drm/i915/icl_dsi.c
+++ b/drivers/gpu/drm/i915/icl_dsi.c
@@ -1133,13 +1133,11 @@ static void gen11_dsi_disable_io_power(struct intel_encoder *encoder)
intel_wakeref_t wakeref;
wakeref = fetch_and_zero(&intel_dsi->io_wakeref[port]);
- if (wakeref) {
- intel_display_power_put(dev_priv,
- port == PORT_A ?
- POWER_DOMAIN_PORT_DDI_A_IO :
- POWER_DOMAIN_PORT_DDI_B_IO,
- wakeref);
- }
+ intel_display_power_put(dev_priv,
+ port == PORT_A ?
+ POWER_DOMAIN_PORT_DDI_A_IO :
+ POWER_DOMAIN_PORT_DDI_B_IO,
+ wakeref);
}
/* set mode to DDI */
--
2.13.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-05 15:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 15:36 [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain() Imre Deak
2019-04-05 15:36 ` Imre Deak [this message]
2019-04-05 17:37 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-04-06 15:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-07 10:48 ` Imre Deak
2019-04-06 16:05 ` [PATCH 1/2] " Chris Wilson
2019-04-07 10:25 ` Imre Deak
2019-04-07 11:41 ` Chris Wilson
2019-04-07 11:55 ` Imre Deak
2019-04-07 12:06 ` Imre Deak
2019-04-07 12:41 ` Chris Wilson
2019-04-07 12:46 ` [PATCH v2 1/2] drm/i915: Get power refs in encoder->get_power_domains() Imre Deak
2019-04-07 13:04 ` Chris Wilson
2019-04-07 13:32 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2) Patchwork
2019-04-07 14:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-08 15:40 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405153657.20921-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox