From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Chiou, Cooper" <cooper.chiou@intel.com>
Cc: jani.nikula@intel.com, Chiou@freedesktop.org,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT
Date: Tue, 9 Apr 2019 15:44:54 +0300 [thread overview]
Message-ID: <20190409124454.GL3888@intel.com> (raw)
In-Reply-To: <1554804428-24215-1-git-send-email-cooper.chiou@intel.com>
On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote:
> VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps
> is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map
> correct values
Eh what? Did someone just change the interpretation of these bits?
> Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data
> rate 000=Default, 001=2.97Gbps, 010=1.65Gbps,
Here you're quoting the values we already use...
> so HDMI_MAX_DATA_RATE_297
> should be 2 and HDMI_MAX_DATA_RATE_165 should be 4
...but here you're using different values again? Which way is it?
>
> TEST: Validated PASS on GLK RVP platform
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Chiou, Cooper <cooper.chiou@intel.com>
> ---
> drivers/gpu/drm/i915/intel_vbt_defs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_vbt_defs.h b/drivers/gpu/drm/i915/intel_vbt_defs.h
> index bf3662ad5fed..e2b8d042912b 100644
> --- a/drivers/gpu/drm/i915/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/intel_vbt_defs.h
> @@ -307,8 +307,8 @@ struct bdb_general_features {
> #define DVO_PORT_MIPID 24 /* 171 */
>
> #define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
> -#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
> -#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
> +#define HDMI_MAX_DATA_RATE_297 2 /* 212 */
> +#define HDMI_MAX_DATA_RATE_165 4 /* 212 */
>
> #define LEGACY_CHILD_DEVICE_CONFIG_SIZE 33
>
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-09 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 10:07 [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT Chiou, Cooper
2019-04-09 11:19 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-09 12:44 ` Ville Syrjälä [this message]
2019-04-09 15:46 ` [PATCH] " Chiou, Cooper
2019-04-09 15:57 ` Ville Syrjälä
2019-04-10 10:08 ` Chiou, Cooper
2019-04-10 10:50 ` Ville Syrjälä
2019-04-10 11:32 ` Chiou, Cooper
2019-04-10 12:23 ` Ville Syrjälä
2019-04-11 3:08 ` Chiou, Cooper
2019-04-09 15:34 ` ✓ Fi.CI.IGT: success for " Patchwork
2019-04-09 17:10 ` ✗ Fi.CI.BAT: failure for drm/i915: Update HDMI max TMDS data rate definition for VBT (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409124454.GL3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Chiou@freedesktop.org \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox